✨ feat: auth 쓸데 없는 async await 키워드 제거 (#17)

f-lab-edu · Dec 6, 2024 · 95ecdac · 95ecdac
1 parent 3438834
commit 95ecdac
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/src/controllers/auth.controller.ts b/src/controllers/auth.controller.ts
@@ -16,29 +16,29 @@ export class AuthController {
     @IsPublicDecorator(IsPublicEnum.PUBLIC)
     @UseGuards(BasicTokenGuard)
     @Post("sign-in")
-    async signIn(@Headers("authorization") rawToken: string) {
+    signIn(@Headers("authorization") rawToken: string) {
         const token = this.authService.extractTokenFromHeader(rawToken, false);
 
         const decoded = this.authService.decodeBasicToken(token);
 
-        return await this.authService.signInByEmail(decoded);
+        return this.authService.signInByEmail(decoded);
     }
 
     @IsPublicDecorator(IsPublicEnum.PUBLIC)
     @Post("sign-up")
-    async signUp(@Body() dto: RegisterMemberDto) {
-        return await this.authService.registerByEmail(dto);
+    signUp(@Body() dto: RegisterMemberDto) {
+        return this.authService.registerByEmail(dto);
     }
 
     @Post("sign-out")
     signOut(@CurrentMemberDecorator("id") memberId: number) {
-        void this.authService.updateRefreshToken(memberId);
+        return this.authService.updateRefreshToken(memberId);
     }
 
     @IsPublicDecorator(IsPublicEnum.PUBLIC)
     @Post("verify-email")
-    async verifyEmail(@Body() dto: VerifyEmailDto) {
-        return await this.authService.verifyEmail(dto);
+    verifyEmail(@Body() dto: VerifyEmailDto) {
+        return this.authService.verifyEmail(dto);
     }
 
     @IsPublicDecorator(IsPublicEnum.REFRESH)

diff --git a/src/services/auth.service.ts b/src/services/auth.service.ts
@@ -98,7 +98,7 @@ export class AuthService {
             verificationCode,
         );
 
-        void this.mailsService.sendVerificationEmail(
+        await this.mailsService.sendVerificationEmail(
             newMember.email,
             verificationCode,
         );