Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] vectorstore hybrid search 기능 추가 #3

Merged
merged 23 commits into from
Dec 2, 2024

Conversation

tmdqja75
Copy link
Collaborator

💻 작업 내용

  • Opensearch Vectorstore docker compose 파일 작성
  • Vectorstore에서 쿼리 관련 documents들을 hybrid search로 retrieve하는 코드 작성

⏩ 앞으로의 과제

  • RAG Pipeline에 Opensearch Vectorstore Retriever 추가

🙋‍♂️ 리뷰 요구사항

  • _reciprocal_rank_fusion 메서드에서 df.apply()에서 사용할 임시 함수 (def ref_score())를 메서드 안에 넣어서 작성했는데, 이런 임시 함수는 클래스 밖으로 따로 빼는게 나을지 궁금합니다!

Copy link

@tmdqja75 tmdqja75 requested a review from f-lab-owen October 21, 2024 15:31
@tmdqja75 tmdqja75 self-assigned this Oct 21, 2024
pyproject.toml Show resolved Hide resolved
app/vectorstore/docker-compose.yaml Show resolved Hide resolved
app/vectorstore/docker-compose.yaml Show resolved Hide resolved
app/vectorstore/opensearch_hybrid.py Outdated Show resolved Hide resolved
app/vectorstore/opensearch_hybrid.py Outdated Show resolved Hide resolved
app/vectorstore/opensearch_hybrid.py Outdated Show resolved Hide resolved
app/vectorstore/opensearch_hybrid.py Show resolved Hide resolved
app/vectorstore/opensearch_hybrid.py Outdated Show resolved Hide resolved
app/vectorstore/opensearch_hybrid.py Show resolved Hide resolved
app/vectorstore/opensearch_hybrid.py Show resolved Hide resolved
Copy link
Collaborator

@f-lab-owen f-lab-owen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

문서 삽입에 실패하는 경우가 고려되어야 합니다. self.vector_store.add_documents 함수에서 성공/실패 정보를 반환하고, 삽입 결과를 토대로 실패시 어떠한 행동을 할지 고민해주시기 바래요

위 코멘트는 선택 반영인 부분이라 일단 어푸로브 하였습니다~!

Copy link

sonarqubecloud bot commented Dec 2, 2024

@tmdqja75 tmdqja75 merged commit ec0e25b into main Dec 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants