실시간 차트 엔티티 설계 #20
Merged
실시간 차트 엔티티 설계 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-조회된 실시간 주식시세 데이터를 데이터베이스에 저장하는 로직 추가
- 불필요한 컬럼 삭제
f-lab-cacio
reviewed
Dec 23, 2024
| @@ -0,0 +1,9 @@ | |||
| package com.flab.mars.db.entity; | |||
|
|
|||
| public enum PriceDataType { | |||
There was a problem hiding this comment.
우선은 "분" 단위 데이터만 다룬다고 가정하시는건 어때요??
그 이후에 다른 단위 데이터로 확장하는 것도 좋아 보입니다
There was a problem hiding this comment.
넵 우선은 분단위만 다룬다고 가정하고 작업하겠습니다!
f-lab-cacio
reviewed
Dec 23, 2024
| @Data | ||
| @NoArgsConstructor | ||
| @AllArgsConstructor | ||
| public class KisPriceResponseVO extends BaseResponseVO { |
There was a problem hiding this comment.
우선은 모든 응답 필드를 다 처리하기보단 저희 도메인에 필요한 데이터만 취급하시죠~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #18