[WIP] Module reorganization #172
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should help avoid packaging tests. Tests are useful for developers, not consumers of the package.
Flit won't add both fabrictestbed_fablib and fabrictestbed_extensions into the wheel package because it is stricter about packaging. This is normally a good thing. However, we want to be able to have some backward-compatible imports at least for a while, so we will switch to setuptools as the build backend.
Because, unlike flit, setuptools_scm picks up version dynamically from Git tags and revisions.
Pull Request Test Coverage Report for Build 5204772487Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
This was
linked to
issues
Jun 7, 2023
Do not use setuptools_scm, because it adds a new thing that we will need to get used to. Instead we will just read the version from __init__.py as we are used to. See: https://packaging.python.org/en/latest/guides/single-sourcing-package-version/
This was we can do `from fabrictestbed_fablib import FablibManager` etc.
This will avoid a circular dependency with init
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue is #164.