Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add documentation to assist deployment changes #51

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

sbose78
Copy link
Member

@sbose78 sbose78 commented Aug 11, 2017

The objective of this documentation is to capture the not-so-obvious deployment decisions.

@hectorj2f hectorj2f self-requested a review August 11, 2017 14:34
Copy link
Contributor

@hectorj2f hectorj2f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


```

- name: OPENSHIFT_KUBE_PING_NAMESPACE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbose78 the kube_pint port is missing here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean among all these details not exactly in this line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants