-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add example for Github Pages deployment; rewrite deployment section #4409
Changes from 5 commits
86e4abb
634c047
81ad1ac
d1ef6fb
b02834e
43f97e9
fcaa277
decd2c4
244229c
d6ee05f
cd1053a
4fe37cb
b20b4da
7ca7c5d
555e810
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -140,14 +140,182 @@ cmd /C 'set "GIT_USER=<GITHUB_USERNAME>" && yarn deploy' | |
|
||
[GitHub Actions](https://help.github.com/en/actions) allow you to automate, customize, and execute your software development workflows right in your repository. | ||
|
||
This workflow assumes your documentation resided in `documentation` branch of your repository and your [publishing source](https://help.github.com/en/github/working-with-github-pages/configuring-a-publishing-source-for-your-github-pages-site) is configured for `gh-pages` branch. | ||
This workflow assumes your documentation resides in the `documentation` branch of your repository and your [publishing source](https://help.github.com/en/github/working-with-github-pages/configuring-a-publishing-source-for-your-github-pages-site) is configured for the `gh-pages` branch. | ||
|
||
Below are two approaches to deploying your docs with GitHub Actions. Follow the example based on if your deployment branch (eg `gh-pages`) is in: | ||
|
||
- The **`same`** repository as your documentation source. | ||
- A **`remote`** repository different from your documentation source. | ||
|
||
````mdx-code-block | ||
<Tabs | ||
defaultValue="same" | ||
values={[ | ||
{ label: 'Same', value: 'same' }, | ||
{ label: 'Remote', value: 'remote' } | ||
]}> | ||
<TabItem value="same"> | ||
|
||
Add these two workflow files for Github Actions to your project: | ||
|
||
```yaml title=".github/workflows/documentation-push.yml" | ||
# Appears in various parts of the Github UI usually with the job name appended. | ||
# (eg Project 'Actions' tab, PR check suite status) | ||
name: 'Docs (Github Pages)' | ||
|
||
on: | ||
# Allows you to manually trigger the workflow from the "Actions" tab. | ||
# You can run the workflow against the latest commit of any branch on the project: | ||
# https://docs.github.com/en/actions/managing-workflow-runs/manually-running-a-workflow | ||
# (This is not required to use "re-run" functionality on prior workflow runs) | ||
workflow_dispatch: | ||
polarathene marked this conversation as resolved.
Show resolved
Hide resolved
|
||
# Build docs pushed to the `documentation` branch, but only *if* the triggering | ||
# commit(s) affect files within the `website` directory (docusaurus project): | ||
push: | ||
branches: | ||
- documentation | ||
paths: | ||
- 'website/**' | ||
# OPTIONAL: Build docs when you push a tag with `v<Major>.<Minor>` substring in the tag name. | ||
# NOTE: The branch and path conditions above have no effect on the tags trigger condition: | ||
tags: | ||
- 'v[0-9]+.[0-9]+*' | ||
polarathene marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
# Jobs will run shell commands from this subdirectory by default: | ||
defaults: | ||
run: | ||
working-directory: website | ||
|
||
# As this workflow example only uses these credentials once, you could instead inline them where they're used. | ||
env: | ||
# Assign commit authorship to official Github Actions bot when pushing to the `gh-pages` branch: | ||
# https://github.com/actions/checkout/issues/13#issuecomment-724415212 | ||
# https://api.github.com/users/github-actions%5Bbot%5D | ||
GIT_USER: 'github-actions[bot]' | ||
polarathene marked this conversation as resolved.
Show resolved
Hide resolved
|
||
GIT_EMAIL: '41898282+github-actions[bot]@users.noreply.github.com' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. where does this email come from? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It comes from where the comments above it clearly state (See the referenced github issue](actions/checkout#13 (comment))). I had the same question when I was trying to resolve this properly and had to seek that information out. There is a user and bot account, the ID value can be verified via the Github API, the e-mail matches what Github provides every user in their settings page to use instead of a personal e-mail: |
||
|
||
# Jobs run in parallel unless you create a `needs` dependency on another job. | ||
# Careful of causing race conditions by triggering multiple jobs that could | ||
# try push to the same branch with conflicting changes. | ||
jobs: | ||
deploy: | ||
name: 'Deploy' | ||
runs-on: ubuntu-20.04 | ||
steps: | ||
# By default performs a shallow clone (project state from that commit): | ||
# (If you need history or other metadata from git, enable `with.fetch-depth: 0`) | ||
# Docs: https://github.com/marketplace/actions/checkout | ||
- uses: actions/checkout@v2 | ||
|
||
# Installs v14 LTS of Node: | ||
# (Uses cached version that Github replaces bi-weekly with latest updates for that version of Node) | ||
# Docs: https://github.com/marketplace/actions/setup-node-js-environment | ||
- name: Setup Node | ||
uses: actions/setup-node@v2 | ||
with: | ||
node-version: '14' | ||
|
||
- name: Get yarn cache | ||
id: yarn-cache | ||
run: echo "::set-output name=dir::$(yarn cache dir)" | ||
|
||
# Cache the yarn cache dir to speed up builds if dependencies haven't changed: | ||
# (Caches are deleted if they've not been used in the past 7 days, | ||
# or the total cache limit of 5GB is exceeded (oldest cache data is evicted first)). | ||
# Docs: https://github.com/actions/cache | ||
- name: Cache dependencies | ||
uses: actions/cache@v2 | ||
with: | ||
path: ${{ steps.yarn-cache.outputs.dir }} | ||
key: ${{ runner.os }}-website-${{ hashFiles('**/yarn.lock') }} | ||
# OPTIONAL: If the cache key does not have a match, `restore-keys` will check for | ||
# previous cache keys with the given prefix and choose the most recent cache: | ||
# https://docs.github.com/en/actions/guides/caching-dependencies-to-speed-up-workflows#matching-a-cache-key | ||
restore-keys: ${{ runner.os }}-website- | ||
|
||
# Install project dependencies, then run the build script from `package.json`: | ||
# (Outputs static docs for hosting to `website/build/`) | ||
- run: yarn install --frozen-lockfile | ||
- run: yarn build | ||
|
||
# Popular action to deploy to gh-pages: | ||
# Docs: https://github.com/peaceiris/actions-gh-pages | ||
- name: 'Deploy to Github Pages' | ||
uses: peaceiris/actions-gh-pages@v3 | ||
with: | ||
# Generated per workflow run, provides automatic auth to push: | ||
# Docs: https://docs.github.com/en/actions/reference/authentication-in-a-workflow#about-the-github_token-secret | ||
github_token: ${{ secrets.GITHUB_TOKEN }} | ||
# Build directory contents to publish to the `gh-pages` branch: | ||
publish_dir: ./website/build | ||
# OPTIONAL: Directory to place `publish_dir` contents on the `gh-pages` branch: | ||
# (Defaults to root of project, removes contents at target dir by default) | ||
# destination_dir: ${{ env.DOCS_VERSION }} | ||
user_name: ${{ env.GIT_USER }} | ||
user_email: ${{ env.GIT_EMAIL }} | ||
``` | ||
|
||
While you can have both jobs defined in the same workflow file, the deploy job as configured in the `remote` example will always be listed as skipped in the PR check suite status. | ||
|
||
That's added noise providing no value to the review process, and as you cannot easily share common snippets like the build process; it is better to manage as separate workflows instead: | ||
|
||
```yaml title=".github/workflows/documentation-pr.yml" | ||
name: 'Docs (PR)' | ||
|
||
# Here the `pull_request` event responds to a PR that is | ||
# `opened`, `reopened` or whenever commits are pushed (`synchronize`), | ||
# these are the default PR activity types to respond to: | ||
# https://docs.github.com/en/actions/reference/events-that-trigger-workflows#pull_request | ||
on: | ||
pull_request: | ||
# The branches here refer to any branch being targeted for a PR to merge into, | ||
# Not the source branch name from the PR author. | ||
branches: | ||
- documentation | ||
paths: | ||
- 'website/**' | ||
|
||
jobs: | ||
verify: | ||
name: 'Verify Build' | ||
runs-on: ubuntu-20.04 | ||
steps: | ||
- uses: actions/checkout@v2 | ||
|
||
- name: Setup node | ||
uses: actions/setup-node@v2 | ||
with: | ||
node-version: '14' | ||
|
||
- name: Get yarn cache | ||
id: yarn-cache | ||
run: echo "::set-output name=dir::$(yarn cache dir)" | ||
|
||
- name: Cache dependencies | ||
uses: actions/cache@v2 | ||
with: | ||
path: ${{ steps.yarn-cache.outputs.dir }} | ||
key: ${{ runner.os }}-website-${{ hashFiles('**/yarn.lock') }} | ||
restore-keys: ${{ runner.os }}-website- | ||
|
||
- name: Install dependencies | ||
working-directory: website | ||
run: yarn install --frozen-lockfile | ||
|
||
- name: Verify docs build successfully | ||
working-directory: website | ||
run: yarn build | ||
``` | ||
|
||
</TabItem> | ||
<TabItem value="remote"> | ||
|
||
1. Generate a new [SSH key](https://help.github.com/en/github/authenticating-to-github/generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent). | ||
1. By default, your public key should have been created in `~/.ssh/id_rsa.pub` or use the name you've provided in the previous step to add your key to [GitHub deploy keys](https://developer.github.com/v3/guides/managing-deploy-keys/). | ||
1. Copy key to clipboard with `xclip -sel clip < ~/.ssh/id_rsa.pub` and paste it as a [deploy key](https://developer.github.com/v3/guides/managing-deploy-keys/#deploy-keys) in your repository. Copy file content if the command line doesn't work for you. Check the box for `Allow write access` before saving your deployment key. | ||
1. You'll need your private key as a [GitHub secret](https://help.github.com/en/actions/configuring-and-managing-workflows/creating-and-storing-encrypted-secrets) to allow Docusaurus to run the deployment for you. | ||
1. Copy your private key with `xclip -sel clip < ~/.ssh/id_rsa` and paste a GitHub secret with name `GH_PAGES_DEPLOY`. Copy file content if the command line doesn't work for you. Save your secret. | ||
1. Create you [documentation workflow file](https://help.github.com/en/actions/configuring-and-managing-workflows/configuring-a-workflow#creating-a-workflow-file) in `.github/workflows/`. In this example it's `documentation.yml`. | ||
2. By default your public key should have been created in `~/.ssh/id_rsa.pub`, or use the name you've provided in the previous step to add your key to [GitHub deploy keys](https://developer.github.com/v3/guides/managing-deploy-keys/). | ||
3. Copy the key to the clipboard with `xclip -sel clip < ~/.ssh/id_rsa.pub` and paste it as a [deploy key](https://developer.github.com/v3/guides/managing-deploy-keys/#deploy-keys) in your repository. Copy the file contents if the command line doesn't work for you. Check the box for `Allow write access` before saving your deployment key. | ||
4. You'll need your private key as a [GitHub secret](https://help.github.com/en/actions/configuring-and-managing-workflows/creating-and-storing-encrypted-secrets) to allow Docusaurus to run the deployment for you. | ||
5. Copy your private key with `xclip -sel clip < ~/.ssh/id_rsa` and paste a GitHub secret with the name `GH_PAGES_DEPLOY`. Copy the file contents if the command line doesn't work for you. Save your secret. | ||
6. Create your [documentation workflow file](https://help.github.com/en/actions/configuring-and-managing-workflows/configuring-a-workflow#creating-a-workflow-file) in `.github/workflows/`. In this example it's `documentation.yml`. | ||
|
||
```yaml title="documentation.yml" | ||
name: documentation | ||
|
@@ -205,9 +373,13 @@ jobs: | |
npm run deploy | ||
``` | ||
|
||
1. Now when a new pull request arrives towards your repository in branch `documentation` it will automatically ensure that Docusaurus build is successful. | ||
1. When pull request is merged to `documentation` branch or someone pushes to `documentation` branch directly it will be built and deployed to `gh-pages` branch. | ||
1. After this step, your updated documentation will be available on the GitHub pages. | ||
</TabItem> | ||
</Tabs> | ||
```` | ||
|
||
1. Now when a new pull request is made to your repository branch `documentation`, it will automatically ensure that the Docusaurus build is successful. | ||
2. When a pull request is merged to the `documentation` branch or someone pushes to the `documentation` branch directly it will be built and deployed to the `gh-pages` branch. | ||
3. After this step your updated documentation will be available on GitHub Pages. | ||
|
||
### Triggering deployment with Travis CI | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Follow the example based on if your deployment branch..." sounds a bit odd to me, maybe rephrase it to:
"Follow the correct example whether you're deployment branch is in one of the following:"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went with a different wording here: fcaa277
If that's not ok, let me know and I'll change it to what you prefer 👍