Add 'unreleased' incremental change log for v15.6.0 #9544
Conversation
CHANGELOG.md
Outdated
|
|
||
| ### React | ||
|
|
||
| * Fix bug where performance entries were being cleared. ([@chrisui](https://github.com/chrisui) in [9451](https://github.com/facebook/react/pull/9451)) |
There was a problem hiding this comment.
Styling nit: some PR links are missing hashes in text
There was a problem hiding this comment.
nice catch - will fix
CHANGELOG.md
Outdated
| ### React | ||
|
|
||
| * Fix bug where performance entries were being cleared. ([@chrisui](https://github.com/chrisui) in [9451](https://github.com/facebook/react/pull/9451)) | ||
| * Stop adding 'px' to numbers passed for CSS Grid attributes. ([@ericsakmar](https://github.com/ericsakmar) in [9185](https://github.com/facebook/react/pull/9185)) |
There was a problem hiding this comment.
Maybe "for unitless CSS Grid attributes"
CHANGELOG.md
Outdated
|
|
||
| * Fix bug where performance entries were being cleared. ([@chrisui](https://github.com/chrisui) in [9451](https://github.com/facebook/react/pull/9451)) | ||
| * Stop adding 'px' to numbers passed for CSS Grid attributes. ([@ericsakmar](https://github.com/ericsakmar) in [9185](https://github.com/facebook/react/pull/9185)) | ||
| * Deprecate `React.createMixin`. ([@aweary](https://github.com/aweary) in [#8853](https://github.com/facebook/react/pull/8853)) |
There was a problem hiding this comment.
Maybe add " which was never used". People might think this is deprecating the mixin system otherwise.
There was a problem hiding this comment.
Nice touch - will fix.
|
The details tag looks so sweet! |
**what is the change?:** Adding a section to the change log where we start accumulating annotations for React v15.6.0. **why make this change?:** - Saves us the trouble of writing the change log entry all at once when we do the release. - Adds transparency about what is in the upcoming release, for those who aren't following facebook#9398 **test plan:** Visual inspection **issue:** facebook#9398
**what is the change?:** - added missing `#` for commit hashes - added minor details to two annotations Thanks to @gaearon for the code review comments. **why make this change?:** Consistency and clarity. **test plan:** Visual inspection **issue:** facebook#9398
flarnie
force-pushed
the
add15-6-UnreleasedSectionToChangelog
branch
from
13758c5 to
31b64c2
Compare
CHANGELOG.md
Outdated
| @@ -28,15 +40,15 @@ | |||
| **Note: this release has a critical issue and was deprecated. Please update to 15.5.4 or higher.** | |||
|
|
|||
| ### React | |||
| * Fix erroneous PropTypes access warning. ([@acdlite](https://github.com/acdlite) in ([ec97ebb](https://github.com/facebook/react/commit/ec97ebbe7f15b58ae2f1323df39d06f119873344)) | |||
| * Fix erroneous PropTypes access warning. ([@acdlite](https://github.com/acdlite) in ([#ec97ebb](https://github.com/facebook/react/commit/ec97ebbe7f15b58ae2f1323df39d06f119873344)) | |||
There was a problem hiding this comment.
Sorry I wasn't being clear. We put # in for PR numbers, but don't include it for commits.
There was a problem hiding this comment.
(For PRs and commits, this is identical to how GH links work if you just paste a link. Unfortunately this doesn't work in Markdown documents, which is why we do this manually.)
There was a problem hiding this comment.
Gotcha - fixing now.
**what is the change?:** We had added hashes to some commit numbers, but ideally only do that for PRs. **why make this change?:** Consistency - this is how github displays those types of links too. PRs get a '#', and commits don't. **test plan:** Visual inspection **issue:** facebook#9398
|
Thanks for the heads up @TrySound - I'll add that PR to the '15.6' changelog after I cherry-pick it. I actually tried yesterday, and got a bunch of failing tests on 15.6 as a result, so need to look into that. |
what is the change?:
Adding a section to the change log where we start accumulating
annotations for React v15.6.0.
why make this change?:
we do the release.
aren't following React 15.6 Umbrella #9398
test plan:
Visual inspection
issue:
#9398