allow seting custom API timeouts #318
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: For config push, firmware upgrade and metrics export we have to have large timeout values (4 minutes). But for the rest we don't. In real world it results in tests being slow running up to 4 minutes per test: ``` # go test github.com/facebook/time/calnex/verify/checks -v === RUN TestGNSS --- PASS: TestGNSS (75.00s) === RUN TestHTTP --- PASS: TestHTTP (75.01s) === RUN TestPing --- PASS: TestPing (1.01s) === RUN TestPSU --- PASS: TestPSU (75.00s) PASS ok github.com/facebook/time/calnex/verify/checks 226.514s ``` Lowering most timeouts expect for aforementioned. Reviewed By: deathowl Differential Revision: D52661410
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52661410 |
|
This pull request has been merged in 1649917. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
For config push, firmware upgrade and metrics export we have to have large timeout values (4 minutes). But for the rest we don't.
In real world it results in tests being slow running up to 4 minutes per test:
Lowering most timeouts expect for aforementioned.
Reviewed By: deathowl
Differential Revision: D52661410