Refactor PPS code #397
Closed
Refactor PPS code #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63386883 |
|
This pull request was exported from Phabricator. Differential Revision: D63386883 |
crmdias
added a commit
to crmdias/time
that referenced
this pull request
Sep 25, 2024
Summary: Pull Request resolved: facebook#397 WHAT? Small refactor WHY? Makes it easier to add mocks and new functionality later Reviewed By: leoleovich Differential Revision: D63386883
crmdias
force-pushed
the
export-D63386883
branch
from
37e367b to
736d0f8
Compare
Summary: Pull Request resolved: facebook#397 WHAT? Small refactor WHY? Makes it easier to add mocks and new functionality later Reviewed By: leoleovich Differential Revision: D63386883
|
This pull request was exported from Phabricator. Differential Revision: D63386883 |
crmdias
force-pushed
the
export-D63386883
branch
from
736d0f8 to
45c64f5
Compare
|
This pull request has been merged in c6c2531. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
WHAT?
Small refactor
WHY?
Makes it easier to add mocks and new functionality later
Reviewed By: leoleovich
Differential Revision: D63386883