Add max frequency parameter #400
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63832053 |
crmdias
added a commit
to crmdias/time
that referenced
this pull request
Oct 8, 2024
Summary:
WHAT?
Add max frequency parameter to ts2phc command
WHY?
Avoid issues where device reports wrong max adjustment value (for instance, driver issues)
Considerations
- Why math.Min(maxFreq, deviceFreq)??
- I want to use the most restrictive value always, so that if device reports lower value, using this configuration does not cause invalid clock steps.
Reviewed By: leoleovich
Differential Revision: D63832053
crmdias
force-pushed
the
export-D63832053
branch
from
660c6b3 to
720a0d0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63832053 |
crmdias
added a commit
to crmdias/time
that referenced
this pull request
Oct 9, 2024
Summary:
WHAT?
Add max frequency parameter to ts2phc command
WHY?
Avoid issues where device reports wrong max adjustment value (for instance, driver issues)
Considerations
- Why math.Min(maxFreq, deviceFreq)??
- I want to use the most restrictive value always, so that if device reports lower value, using this configuration does not cause invalid clock steps.
Reviewed By: leoleovich
Differential Revision: D63832053
crmdias
force-pushed
the
export-D63832053
branch
from
720a0d0 to
5e7586c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63832053 |
crmdias
added a commit
to crmdias/time
that referenced
this pull request
Oct 9, 2024
Summary:
WHAT?
Add max frequency parameter to ts2phc command
WHY?
Avoid issues where device reports wrong max adjustment value (for instance, driver issues)
Considerations
- Why math.Min(maxFreq, deviceFreq)??
- I want to use the most restrictive value always, so that if device reports lower value, using this configuration does not cause invalid clock steps.
Reviewed By: leoleovich
Differential Revision: D63832053
crmdias
force-pushed
the
export-D63832053
branch
from
5e7586c to
1482399
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63832053 |
Summary:
WHAT?
Add max frequency parameter to ts2phc command
WHY?
Avoid issues where device reports wrong max adjustment value (for instance, driver issues)
Considerations
- Why math.Min(maxFreq, deviceFreq)??
- I want to use the most restrictive value always, so that if device reports lower value, using this configuration does not cause invalid clock steps.
Reviewed By: leoleovich
Differential Revision: D63832053
crmdias
force-pushed
the
export-D63832053
branch
from
1482399 to
0391c4b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63832053 |
crmdias
added a commit
to crmdias/time
that referenced
this pull request
Oct 9, 2024
Summary:
WHAT?
Add max frequency parameter to ts2phc command
WHY?
Avoid issues where device reports wrong max adjustment value (for instance, driver issues)
Considerations
- Why math.Min(maxFreq, deviceFreq)??
- I want to use the most restrictive value always, so that if device reports lower value, using this configuration does not cause invalid clock steps.
Reviewed By: leoleovich
Differential Revision: D63832053
|
This pull request has been merged in 0622257. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
WHAT?
Add max frequency parameter to ts2phc command
WHY?
Avoid issues where device reports wrong max adjustment value (for instance, driver issues)
Considerations
Reviewed By: leoleovich
Differential Revision: D63832053