simplify ptpheck map
#406
Closed
simplify ptpheck map
#406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64395255 |
yarikk
added a commit
to yarikk/time
that referenced
this pull request
Oct 15, 2024
Summary: Simplify implementation of the `ptpcheck map` command. Deprecate `phc.IfacesInfo` which is a mere combination of `net.Interfaces` and `phc.IfaceInfo`, was only used in `ptpcheck map` which is simpler AND more optimal without it. Differential Revision: D64395255
yarikk
force-pushed
the
export-D64395255
branch
from
371c087 to
5e5df30
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64395255 |
yarikk
added a commit
to yarikk/time
that referenced
this pull request
Oct 15, 2024
Summary: Simplify implementation of the `ptpcheck map` command. Deprecate `phc.IfacesInfo` which is a mere combination of `net.Interfaces` and `phc.IfaceInfo`, was only used in `ptpcheck map` which is simpler AND more optimal without it. Reviewed By: t3lurid3 Differential Revision: D64395255
yarikk
added a commit
to yarikk/time
that referenced
this pull request
Oct 15, 2024
Summary: Simplify implementation of the `ptpcheck map` command. Deprecate `phc.IfacesInfo` which is a mere combination of `net.Interfaces` and `phc.IfaceInfo`, was only used in `ptpcheck map` which is simpler AND more optimal without it. Reviewed By: t3lurid3 Differential Revision: D64395255
yarikk
force-pushed
the
export-D64395255
branch
from
5e5df30 to
5f75176
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64395255 |
Summary: Deprecate `DeviceFromIface` function which duplicates the functionality of `IfaceToPHCDevice` – retrieving a path to `/dev/ptp𝑛` corresponding to a given network interface. The later is already optimal and has more identifiable references. Reviewed By: abulimov Differential Revision: D64332922
Summary: Simplify implementation of the `ptpcheck map` command. Deprecate `phc.IfacesInfo` which is a mere combination of `net.Interfaces` and `phc.IfaceInfo`, was only used in `ptpcheck map` which is simpler AND more optimal without it. Reviewed By: t3lurid3 Differential Revision: D64395255
yarikk
force-pushed
the
export-D64395255
branch
from
5f75176 to
09ade6f
Compare
yarikk
added a commit
to yarikk/time
that referenced
this pull request
Oct 15, 2024
Summary: Simplify implementation of the `ptpcheck map` command. Deprecate `phc.IfacesInfo` which is a mere combination of `net.Interfaces` and `phc.IfaceInfo`, was only used in `ptpcheck map` which is simpler AND more optimal without it. Reviewed By: t3lurid3 Differential Revision: D64395255
|
This pull request was exported from Phabricator. Differential Revision: D64395255 |
|
This pull request has been merged in 5e20cc7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Simplify implementation of the
ptpcheck mapcommand.Deprecate
phc.IfacesInfowhich is a mere combination ofnet.Interfacesandphc.IfaceInfo, was only used inptpcheck mapwhich is simpler AND more optimal without it.Differential Revision: D64395255