reset FirstUpdate flag on servo after we enter locked state #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Currently we can step at any point in the future if something unexpected happens. We never reset the flag, so techically if the servo was reset we could step multiple times! With this change, once servo is in S2 (locked), we unset the flag. This ensures that we can only step once at the beginning of SPTP lifetime. As a bonus I've added a log message to make it more clear when we step the clock. Reviewed By: leoleovich Differential Revision: D64602914
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64602914 |
|
This pull request has been merged in 54363d7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Currently we can step at any point in the future if something unexpected happens.
We never reset the flag, so techically if the servo was reset we could step multiple times!
With this change, once servo is in S2 (locked), we unset the flag. This ensures that we can only step once at the beginning of SPTP lifetime.
As a bonus I've added a log message to make it more clear when we step the clock.
Reviewed By: leoleovich
Differential Revision: D64602914