fix incorect sign of freqAdj during holdover #419
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: We set an opposite sign frequency (-29874), but were logging the calculated one (+29874): ``` I1030 09:48:56.456448 50105 sptp.go:401] offset Unknown s4 freq +29874 path delay Unknown W1030 09:48:57.457172 50105 sptp.go:408] new best master selected: "2401:db00:2525:f002:face:0:228:0" (b83fd2.fffe.a373ce) I1030 09:48:57.457264 50105 sptp.go:433] offset -17179880252 s3 freq -29874 path delay 8557 (17179888808:-17179871695) ``` Reviewed By: crmdias Differential Revision: D65219367
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65219367 |
|
This pull request has been merged in 3e1b988. |
|
Nice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We set an opposite sign frequency (-29874), but were logging the calculated one (+29874):
Reviewed By: crmdias
Differential Revision: D65219367