CodeGen input and output streams #80
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
At this point, more than actual implementation we care about having the interface ready. It's fine to define those streams as abstract base classes. We want asynchronous streams that can read and write all the
|
* add array support for JDWP DSL * fix schema bugs * update arraytype in AllClasses command * update arraytype in AllClasses command remove error type * fix out and reply mismatch
fix checkers fix: union none to empty set
schema.py type-checks, but raises exception at runtime because Struct is referenced before it is defined. This commit - moves definition of Type to the top - uses string names for forward type references - replaces T with covariant TypeT - fixes missing type parameter in Struct definition
* Added newtype support for primitive type enum * Make newgen generator automatic * Changed type of jdwp_type and changed default type to int * Wrote test to validate primitive type mapping * Added test for type alias definition * Factored out function defining type alias. * Used absolute name format for newtype * Changed testing framework to unittest * Added dependency for jdwp project * Added int and string type * Changed the expected start * Updated test and removed int and byte from primitive types. * Removed int and boolean type from new type generator * doc: add copyright
* add array support for JDWP DSL * fix schema bugs * update arraytype in AllClasses command * update arraytype in AllClasses command remove error type * fix out and reply mismatch
schema.py type-checks, but raises exception at runtime because Struct is referenced before it is defined. This commit - moves definition of Type to the top - uses string names for forward type references - replaces T with covariant TypeT - fixes missing type parameter in Struct definition
Daquiver1
force-pushed
the
codegen_interfaces
branch
from
315ea5d to
b6c07f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.