Skip to content

Commit

Permalink
Remove outdated TODO on Return in LIR generator
Browse files Browse the repository at this point in the history
Summary:
There's nothing stopping us from passing a constant value to the LIR Return
instruction here anymore.  It's already handled in regalloc.

Reviewed By: brittanyrey

Differential Revision: D55969686

fbshipit-source-id: 49f44a52578b369af65065eb25adbf213b724a13
  • Loading branch information
Alex Malyshev authored and facebook-github-bot committed Apr 10, 2024
1 parent 9fea97c commit 29c6237
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion cinderx/Jit/lir/generator.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1095,7 +1095,6 @@ LIRGenerator::TranslatedBlock LIRGenerator::TranslateOneBasicBlock(
break;
}
case Opcode::kReturn: {
// TODO support constant operand to Return
bbb.appendInstr(Instruction::kReturn, i.GetOperand(0));
break;
}
Expand Down

0 comments on commit 29c6237

Please sign in to comment.