Skip to content

Commit

Permalink
Remove unused variables in fbmeshd/rnl/tests/NetlinkSocketTest.cpp (#…
Browse files Browse the repository at this point in the history
…2405)

Summary:
Pull Request resolved: #2405

LLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance.

This diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with `[[maybe_unused]]`, mostly in cases where the variable _is_ used, but, eg, in an `assert` statement that isn't present in production code.

 - If you approve of this diff, please use the "Accept & Ship" button :-)

Reviewed By: palmje

Differential Revision: D57344008

fbshipit-source-id: b5f906e2d4c922590286ab5ecd4df12a3e070075
  • Loading branch information
r-barnes authored and facebook-github-bot committed May 17, 2024
1 parent d538899 commit d09c043
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fbpcs/emp_games/dotproduct/DotproductApp.h
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ class DotproductApp {
std::vector<std::vector<bool>> allLabels;
auto lineNo = 0;

bool success = private_measurement::csv::readCsv(
private_measurement::csv::readCsv(
inputPath,
[&](const std::vector<std::string>& header,
const std::vector<std::string>& parts) {
Expand Down

0 comments on commit d09c043

Please sign in to comment.