refactor(locale): sort person data #3269

ST-DDT · 2024-11-16T11:13:51Z

~~Follow-on to #2265~~ (the actual follow on will be after #3266)

~~infra: implement inactive locales content generation enhancement #2265~~

Preparation for #3266

refactor(locale): filter and cleanup PersonEntryDefintions data #3266

Sorts (and uniques) the entries in the person module definitions in all locales.

The first commit contains the script changes that were used to apply the changes.

netlify · 2024-11-16T11:14:09Z

✅ Deploy Preview for fakerjs ready!

Name	Link
🔨 Latest commit	`d148920`
🔍 Latest deploy log	https://app.netlify.com/sites/fakerjs/deploys/674b6ffada4f34000840f6ba
😎 Deploy Preview	https://deploy-preview-3269.fakerjs.dev
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov · 2024-11-16T11:16:54Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (42083ac) to head (d148920).
Report is 2 commits behind head on next.

Additional details and impacted files

@@           Coverage Diff           @@
##             next    #3269   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files        2806     2806           
  Lines      217140   217140           
  Branches      980      977    -3     
=======================================
+ Hits       217061   217067    +6     
+ Misses         79       73    -6

Files with missing lines	Coverage Δ
src/locales/af_ZA/person/first_name.ts	`100.00% <100.00%> (ø)`
src/locales/af_ZA/person/last_name.ts	`100.00% <100.00%> (ø)`
src/locales/ar/person/first_name.ts	`100.00% <100.00%> (ø)`
src/locales/ar/person/last_name.ts	`100.00% <100.00%> (ø)`
src/locales/ar/person/prefix.ts	`100.00% <100.00%> (ø)`
src/locales/az/person/first_name.ts	`100.00% <100.00%> (ø)`
src/locales/az/person/last_name.ts	`100.00% <100.00%> (ø)`
src/locales/cs_CZ/person/first_name.ts	`100.00% <100.00%> (ø)`
src/locales/cs_CZ/person/last_name.ts	`100.00% <100.00%> (ø)`
src/locales/cs_CZ/person/prefix.ts	`100.00% <100.00%> (ø)`
... and 113 more

... and 1 file with indirect coverage changes

matthewmayer · 2024-11-16T13:27:48Z

This is truncating as well as sorting.

ST-DDT · 2024-11-16T14:04:47Z

This is truncating as well as sorting.

That was not intended. I'll revert it and redo it later.

ST-DDT · 2024-11-17T11:08:16Z

Should be fixed now. The script I have used to sort (and unique) the entries is in the first commit.

matthewmayer · 2024-11-17T11:30:36Z

The only thing I'm concerned about is a theoretical situation where:

There are generic definitions which are not just a merge of male and female
In future we might want to attempt to split the generic definitions into male and female.
The sort order of the generic definitions is useful (eg it's all the male names then all the female names)
And so we'd be losing useful information by sorting.

So I want to manually double check to make sure this is not the case for any locales in this PR.

ST-DDT · 2024-11-17T12:19:22Z

There are generic definitions which are not just a merge of male and female

This PR doesnt change that.

In future we might want to attempt to split the generic definitions into male and female.

That's what the next PR will do.

refactor(locale): filter and cleanup PersonEntryDefintions data #3266

At least for things that can be automated. We can later still do manual adjustments.

The sort order of the generic definitions is useful (eg it's all the male names then all the female names)

That feature will be obsolete with the above cleanup PR anyway. Also according to our definitions update, specifically assignable values dont belong in generic any longer.

So we would only loose that info, if generic is present and specifc entries are missing.
I'll check for that case.

ST-DDT · 2024-11-17T12:45:05Z

ST-DDT · 2024-11-17T12:50:41Z

All last name patterns are basically 1-2 elements and there is no gender aware part/sorting in there (yet).

ST-DDT · 2024-11-17T13:28:46Z

FirstName

En-au-ocker is two concatted sets.
I will create a PR to split it into two.

Ka-Ge is a wild mix of female and male names.
They arent sorted in a particular way, so there is no easy way to split them.
A native speaker has to PR that later.

ST-DDT · 2024-11-17T20:31:55Z

The last names are not sex aware in the relevant locales, so there is nothing to do for us for them.

ST-DDT · 2024-11-17T20:32:49Z

@matthewmayer Does that solve the concerns you are having? Feel free to do your own analysis.

ST-DDT · 2024-11-17T20:33:36Z

Currently blocked by #3270

refactor(locale): split en_AU_ocker first_names by sex #3270

Shinigami92

"LGTM" - no bitcoin miner implementation found 🤣

src/locales/pt_PT/person/prefix.ts

src/locales/es/person/first_name.ts

Issue has been resolved

ST-DDT added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs c: locale Permutes locale definitions m: person Something is referring to the person module labels Nov 16, 2024

ST-DDT added this to the vAnytime milestone Nov 16, 2024

ST-DDT requested review from a team November 16, 2024 11:13

ST-DDT self-assigned this Nov 16, 2024

ST-DDT mentioned this pull request Nov 16, 2024

refactor(person): refine usage of PersonEntryDefinitions #3259

Open

ST-DDT marked this pull request as draft November 16, 2024 14:04

infra: unique and sort person script

10f3ff7

ST-DDT force-pushed the refactor/locale/person/sort branch from 318bac6 to 4847a6b Compare November 17, 2024 10:49

ST-DDT changed the title ~~refactor(locale): normalize person data~~ refactor(locale): sort person data Nov 17, 2024

ST-DDT marked this pull request as ready for review November 17, 2024 10:59

ST-DDT mentioned this pull request Nov 17, 2024

refactor(locale): split en_AU_ocker first_names by sex #3270

Merged

ST-DDT marked this pull request as draft November 17, 2024 13:39

Merge branch 'next' into refactor/locale/person/sort

c1fb4e8

Shinigami92 previously approved these changes Nov 20, 2024

View reviewed changes

ST-DDT requested a review from a team November 20, 2024 17:29

Merge branch 'next' into refactor/locale/person/sort

ae7bd7f

ST-DDT mentioned this pull request Nov 24, 2024

refactor(locale): filter and cleanup PersonEntryDefintions data #3266

Draft

xDivisionByZerox reviewed Nov 24, 2024

View reviewed changes

src/locales/pt_PT/person/prefix.ts Outdated Show resolved Hide resolved

chore: restore comments on pt_PT prefixes

2a93a0d

ST-DDT dismissed Shinigami92’s stale review via 2a93a0d November 24, 2024 20:33

ST-DDT requested review from Shinigami92, xDivisionByZerox and a team November 24, 2024 20:44

xDivisionByZerox approved these changes Nov 24, 2024

View reviewed changes

xDivisionByZerox previously approved these changes Nov 24, 2024

View reviewed changes

matthewmayer previously requested changes Nov 25, 2024

View reviewed changes

src/locales/es/person/first_name.ts Outdated Show resolved Hide resolved

ST-DDT mentioned this pull request Nov 25, 2024

refactor(locale): split up Spanish generic first names #3279

Merged

matthewmayer mentioned this pull request Nov 25, 2024

fix(locale): add Isadora to female names in pt_BR for consistency #3282

Merged

Merge branch 'next' into refactor/locale/person/sort

d0fd68b

ST-DDT dismissed xDivisionByZerox’s stale review via d0fd68b November 25, 2024 20:51

ST-DDT marked this pull request as draft November 25, 2024 20:53

Merge branch 'next' into refactor/locale/person/sort

04b735c

ST-DDT marked this pull request as ready for review November 27, 2024 23:12

ST-DDT requested review from matthewmayer, xDivisionByZerox and a team November 27, 2024 23:12

Merge branch 'next' into refactor/locale/person/sort

d148920

ST-DDT enabled auto-merge November 30, 2024 20:05

ST-DDT disabled auto-merge November 30, 2024 20:08

ST-DDT merged commit 01e20e9 into next Nov 30, 2024
23 checks passed

ST-DDT deleted the refactor/locale/person/sort branch November 30, 2024 20:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(locale): sort person data #3269

refactor(locale): sort person data #3269

ST-DDT commented Nov 16, 2024 •

edited

Loading

netlify bot commented Nov 16, 2024 •

edited

Loading

codecov bot commented Nov 16, 2024 •

edited

Loading

matthewmayer commented Nov 16, 2024

ST-DDT commented Nov 16, 2024

ST-DDT commented Nov 17, 2024

matthewmayer commented Nov 17, 2024

ST-DDT commented Nov 17, 2024

ST-DDT commented Nov 17, 2024 •

edited

Loading

ST-DDT commented Nov 17, 2024

ST-DDT commented Nov 17, 2024 •

edited

Loading

ST-DDT commented Nov 17, 2024

ST-DDT commented Nov 17, 2024 •

edited

Loading

ST-DDT commented Nov 17, 2024

Shinigami92 left a comment

refactor(locale): sort person data #3269

refactor(locale): sort person data #3269

Conversation

ST-DDT commented Nov 16, 2024 • edited Loading

netlify bot commented Nov 16, 2024 • edited Loading

✅ Deploy Preview for fakerjs ready!

codecov bot commented Nov 16, 2024 • edited Loading

Codecov Report

matthewmayer commented Nov 16, 2024

ST-DDT commented Nov 16, 2024

ST-DDT commented Nov 17, 2024

matthewmayer commented Nov 17, 2024

ST-DDT commented Nov 17, 2024

ST-DDT commented Nov 17, 2024 • edited Loading

ST-DDT commented Nov 17, 2024

ST-DDT commented Nov 17, 2024 • edited Loading

ST-DDT commented Nov 17, 2024

ST-DDT commented Nov 17, 2024 • edited Loading

ST-DDT commented Nov 17, 2024

Shinigami92 left a comment

Choose a reason for hiding this comment

ST-DDT commented Nov 16, 2024 •

edited

Loading

netlify bot commented Nov 16, 2024 •

edited

Loading

codecov bot commented Nov 16, 2024 •

edited

Loading

ST-DDT commented Nov 17, 2024 •

edited

Loading

ST-DDT commented Nov 17, 2024 •

edited

Loading

ST-DDT commented Nov 17, 2024 •

edited

Loading