Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve examples for objectKey,objectValue,objectEntry #3339

Merged
merged 3 commits into from
Dec 21, 2024

Conversation

matthewmayer
Copy link
Contributor

fix #3303

@matthewmayer matthewmayer requested a review from a team as a code owner December 20, 2024 11:18
Copy link

netlify bot commented Dec 20, 2024

Deploy Preview for fakerjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit cb907e7
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/6765638566ad1600089c2b95
😎 Deploy Preview https://deploy-preview-3339.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@xDivisionByZerox xDivisionByZerox added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent m: helpers Something is referring to the helpers module labels Dec 20, 2024
@xDivisionByZerox xDivisionByZerox added this to the vAnytime milestone Dec 20, 2024
@xDivisionByZerox xDivisionByZerox requested review from a team December 20, 2024 11:34
Co-authored-by: DivisionByZero <[email protected]>
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

count me as approval when the code formatting was applied

src/modules/helpers/index.ts Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (e0016ad) to head (cb907e7).
Report is 2 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3339   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files        2811     2811           
  Lines      217012   217012           
  Branches      939      937    -2     
=======================================
+ Hits       216959   216961    +2     
+ Misses         53       51    -2     
Files with missing lines Coverage Δ
src/modules/helpers/index.ts 96.71% <ø> (ø)

... and 1 file with indirect coverage changes

Co-authored-by: Shinigami <[email protected]>
@ST-DDT ST-DDT requested review from Shinigami92, xDivisionByZerox and a team December 20, 2024 12:51
@ST-DDT ST-DDT added this pull request to the merge queue Dec 21, 2024
Merged via the queue into faker-js:next with commit 1fd69d9 Dec 21, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation m: helpers Something is referring to the helpers module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

faker.helpers.objectKey and faker.helpers.objectValue examples are not very instructive
4 participants