Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: send empty packet to the client every 600 seconds #112

Merged
merged 1 commit into from
Mar 4, 2024
Merged

fix: send empty packet to the client every 600 seconds #112

merged 1 commit into from
Mar 4, 2024

Conversation

isidentical
Copy link
Collaborator

haven't tested but looks like a super simple way to at least get the logs flowing in. cc: @chamini2

chamini2
chamini2 approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@chamini2 chamini2 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my tests I had an app without logs running for 5+ hours and it still sent when I eventually made a request. So not really certain this will fix. But it does not hurt at all!

@isidentical
Copy link
Collaborator Author

In my tests I had an app without logs running for 5+ hours and it still sent when I eventually made a request

was it using nomad or kubernetes?

@isidentical isidentical merged commit adc8c45 into main Mar 4, 2024
8 checks passed
@isidentical isidentical deleted the send-empty-packet branch March 4, 2024 20:48
@chamini2
Copy link
Member

chamini2 commented Mar 4, 2024

nomad, @isidentical

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chamini2 chamini2 chamini2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isidentical @chamini2