grpc server scaffolding #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanjayprabhu
approved these changes
Nov 6, 2024
| Err(e) => error!(error = ?e, "{}", msg), | ||
| } | ||
|
|
||
| shutdown_tx.send(()).await.ok(); |
There was a problem hiding this comment.
When will this be hit?
There was a problem hiding this comment.
I guess for any reason the grpc server stops running. I'm not sure the full set of cases, but one common one is when the grpc server address/port is already in use.
| @@ -138,7 +180,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> { | |||
| }), | |||
| nonce: tick_count as u64, // Need the nonce to avoid the gossip duplicate message check | |||
| }; | |||
| println!("Registering validator with nonce: {}", register_validator.nonce); | |||
| info!("Registering validator with nonce: {}", register_validator.nonce); | |||
There was a problem hiding this comment.
Thanks, I'll swap the remaining printlns with tracing in my next pr
src/server.rs
Outdated
| pub struct MySnapchainService; | ||
|
|
||
| #[tonic::async_trait] | ||
| impl SnapchainService for MySnapchainService { |
There was a problem hiding this comment.
We should put this into network/
| "src/proto/rpc.proto", | ||
| "src/proto/message.proto", | ||
| "src/proto/username_proof.proto", | ||
| ], &["src/proto"])?; |
There was a problem hiding this comment.
Would be nice to autodiscover all the files, but not a priority
There was a problem hiding this comment.
Good to see this implemented as proposed in issue 5 some days ago
#5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grpc server scaffolding
For now, run on port 50060 +
example:
Note that if the server has an error (e.g. port already in use) it will shutdown the process by sending a signal over a channel.