Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: v2 watcher #2020

Open
wants to merge 2 commits into
base: v2-dev
Choose a base branch
from
Open

Conversation

ErKeLost
Copy link
Member

@ErKeLost ErKeLost commented Dec 23, 2024

refactor watcher

old

this.watcher.watcher.on('')

new

this.watcher.on('')

The first version solves the problem by using the proxy watcher to return the proxy in the constructor

export default class Watcher extends EventEmitter implements IWatcher {
  private watchedFiles = new Set<string>();
  public resolvedWatchOptions: WatchOptions;
  private _watcher: FSWatcher;
  public extraWatchedFiles: string[] = [];

  constructor(public config: ResolvedUserConfig) {
    super();
    this.resolveChokidarOptions();

    const proxy = new Proxy(this, {
      get(target: Watcher, prop: string | symbol) {
        if (prop in target) {
          return target[prop as keyof Watcher];
        }
        if (target._watcher && prop in target._watcher) {
          const value = target._watcher[prop as keyof FSWatcher];
          return typeof value === 'function'
            ? value.bind(target._watcher)
            : value;
        }
        return undefined;
      }
    });

    return proxy as IWatcher;
  }

Existing problem: The type cannot be recognized, even though the emitter custom event is used, it still cannot be used

So the second goal overrides all FsWatcher methods

Maybe have a better way?

Copy link

changeset-bot bot commented Dec 23, 2024

⚠️ No Changeset found

Latest commit: 7fbd430

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "farm-docs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants