Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update api framework #8

Merged
merged 4 commits into from
Nov 30, 2023
Merged

update api framework #8

merged 4 commits into from
Nov 30, 2023

Conversation

edgarriba
Copy link
Member

@edgarriba edgarriba commented Nov 29, 2023 •
edited
Loading

to reproduce:

  • create venv && source it
  • pip install -r requirements.txt
  • DISPLAY=:0 ./entry.sh

guilhermedemouraa
guilhermedemouraa approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@guilhermedemouraa guilhermedemouraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edgarriba edgarriba merged commit 2d701d8 into main Nov 30, 2023
6 checks passed
@edgarriba edgarriba deleted the update-services branch November 30, 2023 12:58
@OloFuchs
Copy link
Contributor

OloFuchs commented Dec 1, 2023

Able to reproduce on lead-mango

  • Images are not updated in real time
    • adding imports, ie changing to decoding using turbo jpeg is not trivial
    • RuntimeError: Unable to locate turbojpeg library automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guilhermedemouraa guilhermedemouraa guilhermedemouraa approved these changes

@Hackerman342 Hackerman342 Awaiting requested review from Hackerman342

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edgarriba @OloFuchs @guilhermedemouraa