Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update controller protos #153

Merged
merged 22 commits into from
Oct 27, 2023
Merged

Update controller protos #153

merged 22 commits into from
Oct 27, 2023

Conversation

Hackerman342
Copy link
Collaborator

No description provided.

@Hackerman342 Hackerman342 changed the title Add ControllerTrack proto and conversion util Add ControllerTrack proto Oct 9, 2023
@Hackerman342 Hackerman342 deleted the controller-track branch October 9, 2023 20:05
@Hackerman342 Hackerman342 restored the controller-track branch October 19, 2023 19:03
@Hackerman342 Hackerman342 reopened this Oct 19, 2023
@Hackerman342 Hackerman342 changed the title Add ControllerTrack proto Update controller protos Oct 19, 2023
@Hackerman342 Hackerman342 marked this pull request as ready for review October 19, 2023 21:34
Copy link
Contributor

@guilhermedemouraa guilhermedemouraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. I may still some ideas for the filter debugging stuff

protos/farm_ng/control/control.proto Outdated Show resolved Hide resolved
protos/farm_ng/control/control.proto Outdated Show resolved Hide resolved
protos/farm_ng/control/control.proto Outdated Show resolved Hide resolved
protos/farm_ng/control/control.proto Show resolved Hide resolved
Copy link
Contributor

@mihelich mihelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also discussed:

  1. Remove FilterTrack.
  2. Generally rename Controller stuff to TrackFollower.

It's fine if those are in follow-up PR(s), just want to make sure they don't get lost.

protos/farm_ng/control/control.proto Outdated Show resolved Hide resolved
protos/farm_ng/control/control.proto Outdated Show resolved Hide resolved
protos/farm_ng/control/control.proto Outdated Show resolved Hide resolved
protos/farm_ng/control/control.proto Outdated Show resolved Hide resolved
protos/farm_ng/control/control.proto Outdated Show resolved Hide resolved
py/examples/controller_track/main.py Outdated Show resolved Hide resolved
py/examples/controller_square/main.py Show resolved Hide resolved
py/examples/controller_square/main.py Outdated Show resolved Hide resolved
protos/farm_ng/control/control.proto Show resolved Hide resolved
Copy link
Contributor

@mihelich mihelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hackerman342 looks great, thanks! I had a couple final comments on enum style. I think there's more we can do in general to set up our gRPC APIs to change gracefully in the future, but I'll leave it there... let's get this in and unblock the feature work.

protos/farm_ng/control/control.proto Show resolved Hide resolved
protos/farm_ng/control/control.proto Outdated Show resolved Hide resolved
@Hackerman342 Hackerman342 merged commit b26e808 into main-v2 Oct 27, 2023
2 checks passed
@Hackerman342 Hackerman342 deleted the controller-track branch October 27, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants