-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update controller protos #153
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent. I may still some ideas for the filter debugging stuff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also discussed:
- Remove
FilterTrack
. - Generally rename
Controller
stuff toTrackFollower
.
It's fine if those are in follow-up PR(s), just want to make sure they don't get lost.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hackerman342 looks great, thanks! I had a couple final comments on enum style. I think there's more we can do in general to set up our gRPC APIs to change gracefully in the future, but I'll leave it there... let's get this in and unblock the feature work.
No description provided.