feat: support env filter #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
andylokandy
reviewed
Aug 16, 2024
| use logforth::Dispatch; | ||
| use logforth::Logger; | ||
|
|
||
| fn main() { |
There was a problem hiding this comment.
It may be better if you add some examples of command line args for different env filter cases.
There was a problem hiding this comment.
Things like RUST_LOG=info cargo run --features="env-filter" --example env_filter ..
I don't find a place suitable for this and would prefer to postpone it as a follow-up.
andylokandy
reviewed
Aug 16, 2024
| @@ -89,7 +89,7 @@ impl<const LAYOUT: bool, const APPEND: bool> Dispatch<LAYOUT, APPEND> { | |||
| impl Dispatch { | |||
| fn enabled(&self, metadata: &Metadata) -> bool { | |||
There was a problem hiding this comment.
This is function unused?
andylokandy
approved these changes
Aug 16, 2024
Signed-off-by: tison <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #54