Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add missing use strict directives #267

Merged
merged 1 commit into from
Oct 18, 2023
Merged

test: add missing use strict directives #267

merged 1 commit into from
Oct 18, 2023

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Oct 18, 2023

Checklist

@Uzlopak
Copy link
Contributor

Uzlopak commented Oct 18, 2023

Isnt there a eslint rule?

@Fdawgs
Copy link
Member Author

Fdawgs commented Oct 18, 2023

Isnt there a eslint rule?

There is, that's how i'm picking these up :)

@Uzlopak Uzlopak merged commit 8da0a48 into master Oct 18, 2023
17 checks passed
@Uzlopak Uzlopak deleted the test/strict branch October 18, 2023 15:51
Uzlopak added a commit that referenced this pull request Oct 18, 2023
@Uzlopak
Revert "test: add missing use strict directives (#267)"
e239703 
This reverts commit 8da0a48.
@Fdawgs
Copy link
Member Author

Fdawgs commented Oct 18, 2023

@Uzlopak what happened with the revert here?

@Uzlopak
Copy link
Contributor

Uzlopak commented Oct 18, 2023

Misstyped on my mobile. Thought it had no effect. Did it effected master?

@Fdawgs
Copy link
Member Author

Fdawgs commented Oct 18, 2023

Ah, master is good. Ignore me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Uzlopak Uzlopak Uzlopak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fdawgs @Uzlopak