Consistently use Error::NotAvailable instead of Unsupported #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Unsupported` is meant to express things that are not supported by the platform, for example trying to make a request with "HTTP/4". `NotAvailable` is meant to express things that are not available or unimplemented in Viceroy. Previously, `Unsupported` would return `FastlyStatus::Unsupported` and `NotAvailable` would return the generic `FastlyStatus::Error`. This led to a bad user experience for the `NotAvailable` case, as the user would see an opaque and generic "Error" message rather than "Unsupported". The previous commit fixes this by having both `Unsupported` and `NotAvailable` return `FastlyStatus::Unsupported`. This commit makes our use of `NotAvailable` consistent.
cee-dub
approved these changes
Mar 12, 2024
JakeChampion
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches most uses of
Error::UnsupportedtoError::NotAvailable, and translates both toFastlyStatus::Unsupported.Unsupportedis meant to express things that are not supported by the platform, for example trying to make a request with "HTTP/4".NotAvailableis meant to express things that are not available or unimplemented in Viceroy.Previously,
Unsupportedwould returnFastlyStatus::UnsupportedandNotAvailablewould return the genericFastlyStatus::Error. This led to a bad user experience for theNotAvailablecase, as the user would see an opaque and generic "Error" message rather than indicating an operation was "Unsupported".This PR (1) changes
Error::NotAvailableto map toFastlyStatus::Unsupportedand (2) changes all our uses ofError::Unsupportedfor things that are not implemented in Viceroy to beError::NotAvailable.