Stop using onSpinWait #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add default transform as default Reduce complex choice
|
Resolves #194 |
mikejritter
approved these changes
May 23, 2024
There was a problem hiding this comment.
Works as expected, I see a drop in cpu usage when running compared to main 👍
The solr changes look ok as well, and all tests passed when building.
One thing that I noticed is that I'm always getting a non-zero exit code, but I think that can be a separate ticket as that happens on main as well. It's not really a big deal but would be nice for e.g. sigterm being sent.
whikloj
added a commit
that referenced
this pull request
Sep 12, 2024
* Initial commit of solr basic auth functionality * reducing log level of solr indexer when using auth * FCREPO-3834 Enable Camel toolbox to send xml records to Solr indexing service (#191) * replacing ldpath service with XSLT processing solr indexer * no longer need HTTP_URI * added properties for new solr xsl transforms to docker-compose properties file * returning config to original state rather than my dev stack * adding fields to solr xsl --------- Co-authored-by: Dan Field <[email protected]> * [maven-release-plugin] prepare release fcrepo-camel-toolbox-6.1.0 * [maven-release-plugin] prepare for next development iteration * Stop using onSpinWait (#203) Alters Thread.onSpinWait to use latch and await to avoid using CPU cycles to wait. Also adds additional debug/trace logging to Solr route Adds the default transform as the default on the property for Solr indexing Adds some additional documentation on Solr indexing. * Alterations at Jared's request on PR * Initial commit of solr basic auth functionality * reducing log level of solr indexer when using auth * Alterations at Jared's request on PR --------- Co-authored-by: Jared Whiklo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket: https://fedora-repository.atlassian.net/browse/FCREPO-3940
What does this Pull Request do?
Alters Thread.onSpinWait to use latch and await to avoid using CPU cycles to wait.
Also adds additional debug/trace logging to Solr route
Adds the default transform as the default on the property for Solr indexing
Adds some additional documentation on Solr indexing.
How should this be tested?
Run the camel-toolbox before this PR and see 95-100% CPU usage by java when no messages are being processed, after this is much lower. (Credit to @pwinckles for the work)
You can also increase the log level to trace to see additional messages.
Lastly before this PR if you do not define the
solr.fcrepo.defaultTransformproperty there is no default transform. After you will get the internal one.Additional Notes:
Any additional information that you think would be helpful when reviewing this PR.
Example:
Interested parties
Tag (@ mention) interested parties or, if unsure, @fcrepo/committers