Skip to content

Commit

Permalink
incorporating code review comments.
Browse files Browse the repository at this point in the history
Signed-off-by: Lokesh Rangineni <[email protected]>
  • Loading branch information
lokeshrangineni committed Jun 13, 2024
1 parent 294611e commit 956a26c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
3 changes: 0 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -377,9 +377,6 @@ kill-trino-locally:
install-protoc-dependencies:
pip install --ignore-installed protobuf==4.24.0 "grpcio-tools>=1.56.2,<2" mypy-protobuf==3.1.0

install-feast-ci-locally:
pip install -e ".[ci]"

# Docker

build-docker: build-feature-server-python-aws-docker build-feature-transformation-server-docker build-feature-server-java-docker
Expand Down
6 changes: 3 additions & 3 deletions sdk/python/feast/infra/online_stores/remote.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def online_write_batch(
],
progress: Optional[Callable[[int], Any]],
) -> None:
pass
raise NotImplementedError

def online_read(
self,
Expand Down Expand Up @@ -156,12 +156,12 @@ def update(
entities_to_keep: Sequence[Entity],
partial: bool,
):
pass
raise NotImplementedError

def teardown(
self,
config: RepoConfig,
tables: Sequence[FeatureView],
entities: Sequence[Entity],
):
pass
raise NotImplementedError

0 comments on commit 956a26c

Please sign in to comment.