feat: Add the ability to list objects by tags

[tchughesiv]

What this PR does / why we need it:

In the feast registry & cli, add the ability to list objects by tags... same as the UI already supports.
Here are the object types with this new --tags capability -

• data-sources (DataSource)
• entities (Entity)
• feature-services (FeatureService)
• feature-views (FeatureView)
• on-demand-feature-views (OnDemandFeatureView)
• StreamFeatureView

Which issue(s) this PR fixes:

Fixes: #4245

e.g.

$ feast feature-views list --help
Usage: feast feature-views list [OPTIONS]

  List all feature views

Options:
  --tags TEXT  Filter by tags (e.g. --tags 'key:value' --tags 'key:value,
               key:value, ...'). Items return when ALL tags match.
  --help       Show this message and exit.

$ feast feature-views list --tags team:driver_performance              
NAME                       ENTITIES    TYPE
driver_hourly_stats        {'driver'}  FeatureView
driver_hourly_stats_fresh  {'driver'}  FeatureView

$ feast feature-views list
NAME                       ENTITIES    TYPE
driver_hourly_stats        {'driver'}  FeatureView
driver_hourly_stats_fresh  {'driver'}  FeatureView
transformed_conv_rate_fresh  {'driver'}  OnDemandFeatureView
transformed_conv_rate        {'driver'}  OnDemandFeatureView

[lokeshrangineni]

/LGTM

[tokoko]

We should probably follow up (maybe in other PRs) with similar changes for other feast objects that have tags (entities, data sources). Seems odd to have this only for feature views.

[tchughesiv]

@tokoko i didn't realize that about the other objects. maybe its better to go ahead and add to this PR? where can i find a definitive list of the objects with tags? any docs? or should i just parse the code?

[tokoko]

Yeah, changes to others in this PR would be great. All the objects in BaseRegistry are worth checking out, but I don't think all of them have a list command in cli, so might be a moot point for some for now. You can simply go ahead and implement it for all *_list methods in cli.py (feature view, data source, entity, feature service, on demand feature view).

[dmartinol]

We should probably follow up (maybe in other PRs) with similar changes for other feast objects that have tags (entities, data sources). Seems odd to have this only for feature views.

@tokoko, I would also add that, since the direction is to expose authorized access through Feast services, we should include the same filtering by tags for all List APIs in RegistryServer. What do you think?

[tokoko]

@dmartinol Yeah, I guess that's implied. Whatever changes we make to BaseRegistry will have to be reflected in RegistryServer as well.

[tchughesiv]

@tokoko @dmartinol i've added filtering by tags to all feast objects that have the tags field.

[tokoko]

@tchughesiv Looks good to me, but better place for tests is in test_universal_registry.py. That's the one that's run for all registry implementations.

[dmartinol]

👍 @tchughesiv shouldn't we also update the documentation for the CLI options?
BTW: unless you think it's obvious, I would also explain that all tags must match to satisfy the filtering condition (ATM there's no way to select resources matching any of the given tags)

[tokoko]

@dmartinol I also had to check in the code that all tags had to match lol. Maybe it should have been, but wasn't obvious to me.

[tchughesiv]

@dmartinol @tokoko thanks for the reviews. i've made the requested changes, including improved docs and additional tests in test_universal_registry.py

[tokoko]

LGTM

[jeremyary]

Thanks all for the reviews & feedback!