fix: Refactor Operator to deploy all feast services to the same Deployment/Pod #4863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchughesiv
force-pushed
the
singleDeployNew
branch
3 times, most recently
from
45621f9 to
ffe3ee1
Compare
Signed-off-by: Tommy Hughes <[email protected]>
tchughesiv
force-pushed
the
singleDeployNew
branch
from
663cd86 to
953b79e
Compare
| } | ||
| } | ||
|
|
||
| func mountTlsRemoteRegistryConfig(feastType FeastServiceType, podSpec *corev1.PodSpec, tls *feastdevv1alpha1.TlsRemoteRegistryConfigs) { | ||
| func mountTlsRemoteRegistryConfig(podSpec *corev1.PodSpec, tls *feastdevv1alpha1.TlsRemoteRegistryConfigs) { |
There was a problem hiding this comment.
just curious, TlsRemoteRegistryConfigs existing only for registry? not for other offline and online?
There was a problem hiding this comment.
just curious, TlsRemoteRegistryConfigs existing only for registry?
correct... in the event a remote registry is specified by the user with TLS configured via services.registry.remote.tls, the online/offline containers will need the public cert (or CA) in order to communicate with said remote registry.
not for other offline and online?
with this function the online/offline containers are configured with the remote registry's TLS volume.
Signed-off-by: Tommy Hughes <[email protected]>
franciscojavierarceo
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Current Operator approach to Feast deployment relies heavily on the remote provider type and feast server interaction over k8s services. This PR pulls feast services into a single Pod (but still separate containers) which allows for a more traditional Feast stack configuration. Each feast service container is able to share things like storage, feature_repo, and the feature_store.yaml.
Which issue(s) this PR fixes:
Fixes #4866 & #4848