Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Improve status.applied updates & add offline pvc unit test #4871

Merged
merged 1 commit into from
Dec 23, 2024
Merged

fix: Improve status.applied updates & add offline pvc unit test #4871

merged 1 commit into from
Dec 23, 2024

Conversation

tchughesiv
Copy link
Contributor

@tchughesiv tchughesiv commented Dec 21, 2024 •
edited
Loading

What this PR does / why we need it:

  • Change order of status.applied update to avoid conflicts & ensure all defaults are properly set
  • Add offline PVC unit test to ensure ephemeral registry & online paths are updated accordingly
  • Minor code improvements

Which issue(s) this PR fixes:

Relates to #4866

Misc

@tchughesiv tchughesiv requested a review from a team as a code owner December 21, 2024 16:36
@tchughesiv tchughesiv changed the title fix: Improve status.applied update & add offline pvc unit test fix: Improve status.applied updates & add offline pvc unit test Dec 21, 2024
@tchughesiv tchughesiv merged commit 3f49517 into feast-dev:master Dec 23, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franciscojavierarceo franciscojavierarceo franciscojavierarceo approved these changes

Assignees
No one assigned
Labels
ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tchughesiv @franciscojavierarceo