Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the first integration test #124

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Add the first integration test #124

wants to merge 19 commits into from

Conversation

illright
Copy link
Member

@illright illright commented Nov 12, 2024

First step towards #30

Copy link

changeset-bot bot commented Nov 12, 2024

🦋 Changeset detected

Latest commit: bbccb4e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
steiger Patch
@steiger/integration-tests Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@illright illright marked this pull request as draft November 12, 2024 19:41
@illright illright changed the title E2E Add the first integration test Dec 27, 2024
@illright illright requested a review from daniilsapa December 27, 2024 00:26
@illright illright marked this pull request as ready for review December 27, 2024 00:27
daniilsapa
daniilsapa previously approved these changes Jan 2, 2025
Copy link
Collaborator

@daniilsapa daniilsapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! It's a good start with tests!

I only have one question and one optional suggestion.

Why have you stopped considering this test as an e2e test? Doesn't it test the application as a whole?

If you find it relevant, could you document the approach to adding more tests in the future? A short guide, like:

  • Add posix test
  • Run update-windows-snapshots
  • Run tests
  • Commit the results

but maybe in more details

Copy link

pkg-pr-new bot commented Jan 2, 2025

Open in Stackblitz

npm i https://pkg.pr.new/feature-sliced/steiger@124
npm i https://pkg.pr.new/feature-sliced/steiger/@steiger/toolkit@124
npm i https://pkg.pr.new/feature-sliced/steiger/@feature-sliced/steiger-plugin@124

commit: 8e5dc99

@illright
Copy link
Member Author

illright commented Jan 3, 2025

Why have you stopped considering this test as an e2e test? Doesn't it test the application as a whole?

I decided to call them "integration tests" because there are still aspects in a user journey that we are not testing — downloading the package from npm, colors in output, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants