-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the first integration test #124
base: master
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: bbccb4e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! It's a good start with tests!
I only have one question and one optional suggestion.
Why have you stopped considering this test as an e2e test? Doesn't it test the application as a whole?
If you find it relevant, could you document the approach to adding more tests in the future? A short guide, like:
- Add posix test
- Run update-windows-snapshots
- Run tests
- Commit the results
but maybe in more details
commit: |
I decided to call them "integration tests" because there are still aspects in a user journey that we are not testing — downloading the package from npm, colors in output, etc. |
First step towards #30