Fix 404s in rule description links #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5ee86a2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
illright
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Two organizational things:
- Could you remove the "Resolves" from the PR description? It doesn't fix all of the problems in that issue, so we don't want to close the issue by merging this
- If it's not a hassle, could you make an issue to move the URL descriptions to plugins? Otherwise I can also make it
|
|
But gimme a half an hour, maybe I'll come up with a fix for the other issue |
daniilsapa
changed the title
|
@illright |
|
I'd prefer if we separated PRs because it will simplify review. We can still link them to the issue with the word "References" (won't close it) |
daniilsapa
changed the title
illright
deleted the
hotfix/fix-links-and-insignificant-slice-diagnostics
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #122