Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widgets are falsely marked as not referenced #83

Merged
merged 3 commits into from
Oct 19, 2024

Conversation

Desteel
Copy link
Contributor

@Desteel Desteel commented Aug 15, 2024

Resolves 78

tsconfck only handles the first level of referenced (and perhaps it won't be changed).

Anyway, it is already enough to cover general cases, like:

  • vite tsconfig's referenced;
  • monorepo, assuming that the steiger is run for a specific subproject;
  • monorepo, assuming that only the first level of referenced is used (which is expected)

In the future, if the tsconfck behavior is changed, it will be used by default.

Copy link
Member

@illright illright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR, I just don't think we should make this functionality exclusive to the FSD plugin of Steiger :D How about we make these changes in @feature-sliced/filesystem instead?

illright
illright previously approved these changes Oct 19, 2024
Copy link
Member

@illright illright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I changed my mind, this function doesn't belong in the @feature-sliced/filesystem package. It doesn't belong to the FSD plugin either, but a better way to implement it needs some more thinking, so it will probably land in the next release of Steiger (see #107).

Thanks for this PR! Sorry it took so long :D

@illright illright merged commit 8291fc7 into feature-sliced:master Oct 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Widgets are falsely marked as not referenced
2 participants