Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: support create/delete playlist #731

Merged
merged 4 commits into from
Oct 23, 2023

Conversation

cosven
Copy link
Member

@cosven cosven commented Oct 17, 2023

No description provided.

@coveralls
Copy link

coveralls commented Oct 17, 2023

Pull Request Test Coverage Report for Build 6615205495

  • 24 of 87 (27.59%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 57.104%

Changes Missing Coverage Covered Lines Changed/Added Lines %
feeluown/library/provider_protocol.py 8 9 88.89%
feeluown/gui/widgets/playlists.py 3 25 12.0%
feeluown/gui/uimain/sidebar.py 13 53 24.53%
Totals Coverage Status
Change from base Build 6550127281: -0.2%
Covered Lines: 8918
Relevant Lines: 15617

💛 - Coveralls

def popup_playlist_adding_dialog(self):
provider_ui = self._app.current_pvd_ui_mgr.get()
if provider_ui is not None:
if isinstance(provider_ui, UISupportsCreatePlaylist):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以把 CreatePlaylist 变成 CreatePlaylistWithName,这样就可以更好的共享代码了

@cosven cosven merged commit 9a7e488 into feeluown:master Oct 23, 2023
8 checks passed
@cosven cosven deleted the playlist-create-delete branch October 23, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants