Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

player: some improvements about the player #739

Merged
merged 2 commits into from
Dec 10, 2023

Conversation

cosven
Copy link
Member

@cosven cosven commented Dec 10, 2023

  1. stop the player immediately when user plays a song, so that user knows the action is handling
  2. remove some misleading logs from the playlist module
  3. fill the cover_label with random color when cover is not available

@coveralls
Copy link

coveralls commented Dec 10, 2023

Pull Request Test Coverage Report for Build 7158504609

  • 45 of 79 (56.96%) changed or added relevant lines in 7 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.06%) to 57.191%

Changes Missing Coverage Covered Lines Changed/Added Lines %
feeluown/library/models.py 1 2 50.0%
feeluown/gui/components/line_song.py 5 8 62.5%
feeluown/gui/uimain/player_bar.py 3 6 50.0%
feeluown/player/playlist.py 19 22 86.36%
feeluown/gui/widgets/cover_label.py 4 9 44.44%
feeluown/gui/drawers.py 11 30 36.67%
Files with Coverage Reduction New Missed Lines %
feeluown/gui/drawers.py 1 50.63%
Totals Coverage Status
Change from base Build 6946375179: 0.06%
Covered Lines: 9031
Relevant Lines: 15791

💛 - Coveralls

@cosven cosven merged commit fa30b3f into feeluown:master Dec 10, 2023
10 checks passed
mokurin000 pushed a commit to waylyrics/FeelUOwn that referenced this pull request Jan 11, 2024
1. stop the player immediately when user plays a song, so that user knows the action is handling
2. remove some misleading logs from the playlist module
3. fill the cover_label with random color when cover is not available
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants