Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui: add recommendation page #742

Merged
merged 3 commits into from
Jan 3, 2024
Merged

gui: add recommendation page #742

merged 3 commits into from
Jan 3, 2024

Conversation

cosven
Copy link
Member

@cosven cosven commented Jan 2, 2024

基本思路:为了“写最少的代码,实现最多的功能”,资源提供方尽量只提供数据,由 FeelUOwn 来实现 UI。这样的好处是尽可能复用代码;对“前后端分离”理论上也是有好处的。

对于“推荐页”这个功能,后续还有以下 TODO

  • 对不支持“推荐”的资源提供方来说,需要一个合理的错误提示页面

最好还可以完善一下

  • 为 ImgCardListView 提供翻页功能

image

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7398143935

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 56.833%

Totals Coverage Status
Change from base Build 7356377005: -0.3%
Covered Lines: 9095
Relevant Lines: 16003

💛 - Coveralls

@cosven cosven merged commit 893d790 into feeluown:master Jan 3, 2024
9 of 10 checks passed
mokurin000 pushed a commit to waylyrics/FeelUOwn that referenced this pull request Jan 11, 2024
1. daily recommended songs
2. daily recommended playlists
3. show rank(排行榜) button (but not implemented)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants