Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: windows SystemMediaTransportControls integration #755

Merged
merged 55 commits into from
Jan 24, 2024
Merged

fix: windows SystemMediaTransportControls integration #755

merged 55 commits into from
Jan 24, 2024

Conversation

mokurin000
Copy link
Contributor

@mokurin000 mokurin000 commented Jan 11, 2024 •
edited
Loading

Todo

Status

Support Play/Pause Previous Next Thumbnail Media Title Media Artist App Info Shuffle Repeat Stop Timeline information
🟢 🟩 🟩 🟩 🟩 🟩 🟩 🟩 🟩 🟩 🟪 🟩

reopened due to branch rename

cosven and others added 30 commits January 7, 2024 12:17
@cosven
set upper version for batteries
5657126
@mokurin000
[ci skip] also include *.mo and *.po
083c324
@mokurin000
Update hook-feeluown.py
fb70b7a
@mokurin000
switch to aionowplaying master branch
70d09ad
@mokurin000
fix informed url
b1eff8a
@mokurin000
fix use https protocol
2b5bc0c
@mokurin000
fix py3.12 support
6424ae9
@mokurin000
fix: windows SMTC integration
7180a8f
@mokurin000
fix fuo_ytmusic disturbution (#1)
70dd71b 
* Update hook-feeluown.py

* fix: no need to include *.mo

* fix typo
@mokurin000
plugin: support 3.8-3.12~
69fee84
@mokurin000
nowplaying: remove debug print
0c5e91c
@mokurin000
nowplaying: chore: function rename
11452f4
@mokurin000
fix ill-formed git branch url
8f0124c
@mokurin000
fix pylint & flake8
70336f5
@mokurin000
distribution: fix feeluown#748 (feeluown#749)
3ec1cb9
@mokurin000
feat: set id_ for windows nowplaying
3608599
@mokurin000
packaging(win): append details to windows packaged executable
9f296e1
@mokurin000
fix(ci): install pyinstaller-versionfile
91fcb7c
@mokurin000
Merge branch 'branch-3.8.x' into dev-3.8.x
0d7140a
@cosven @mokurin000
*: introduce webserver (optional, experimental) (feeluown#736)
ffbea0b
@felixonmars @mokurin000
docs: update Arch Linux package URL in quickstart.rst (feeluown#738)
e3acd31 
The old URL returns 404 now.
@cosven @mokurin000
serializer: add type info in serialized result and json-rpc (feeluown…
9e9d2a6 
…#737)
@cosven @mokurin000
player: some improvements about the player (feeluown#739)
06a4e5e 
1. stop the player immediately when user plays a song, so that user knows the action is handling
2. remove some misleading logs from the playlist module
3. fill the cover_label with random color when cover is not available
@cosven @mokurin000
gui: introduce UISupportsDiscovery protocol (feeluown#740)
ad2cea1
@cosven @mokurin000
gui: redesign ImgListView and rename some modules (feeluown#741)
0336a56
@cosven @mokurin000
gui: add recommendation page (feeluown#742)
e8d16ee 
1. daily recommended songs
2. daily recommended playlists
3. show rank(排行榜) button (but not implemented)
@cosven @mokurin000
player: try to find standby when there is unknown expcetion (feeluown…
f255e30 
…#743)
@cosven @mokurin000
gui: add fav page (feeluown#744)
c82e6ed 
1. add fav page
2. introduce several protocols
    - SupportsCurrentUserFavSongsReader
    - SupportsCurrentUserFavAlbumsReader
    - SupportsCurrentUserFavArtistsReader
    - SupportsCurrentUserFavPlaylistsReader
    - SupportsCurrentUserFavVideosReader
@cosven @mokurin000
gui: introduce UISupportsLoginEvent protocol (feeluown#745)
d38a67f
@cosven @mokurin000
*: remove model v1 (feeluown#746)
dafcacb
@mokurin000 mokurin000 marked this pull request as ready for review January 11, 2024 08:43
@coveralls
Copy link

coveralls commented Jan 11, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7631855666

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.007%) to 55.269%
Totals Coverage Status
Change from base Build 7622603715: -0.007%
Covered Lines: 8623
Relevant Lines: 15602
💛 - Coveralls

@mokurin000
Copy link
Contributor Author

mokurin000 commented Jan 11, 2024 •
edited
Loading

copied from cosven

试了试这个 stop，感觉是存在一个刷新问题。

我试了试，这样是可以让它的 button 变为可用。

  1. 正常启动播放器
  2. 手动调用 service._controls.is_enable = False
  3. 然后手动再启用它，按钮就可用了

还有一种情况，按钮也可以：先启动 fuo，后启动 flyouts 组件，这样按钮也可以用。|

测了测，还发现

  1. 直接修改 is_next_enabled 属性，UI 不会变。
  2. 如果 disable -> 修改 -> enable 这样 UI 就能刷新。

cosven
cosven reviewed Jan 23, 2024
View reviewed changes
feeluown/plugin.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@cosven cosven merged commit 6164f48 into feeluown:master Jan 24, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cosven cosven cosven approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mokurin000 @coveralls @cosven @felixonmars