Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix](*) several bugfix #891

Merged
merged 5 commits into from
Dec 1, 2024
Merged

[bugfix](*) several bugfix #891

merged 5 commits into from
Dec 1, 2024

Conversation

cosven
Copy link
Member

@cosven cosven commented Dec 1, 2024

  • allow assign to undeclared config field
  • reduce unused logs

@coveralls
Copy link

coveralls commented Dec 1, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12105343568

Details

  • 26 of 48 (54.17%) changed or added relevant lines in 7 files are covered.
  • 4 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.04%) to 56.726%
Changes Missing Coverage Covered Lines Changed/Added Lines %
feeluown/config.py 19 20 95.0%
feeluown/task.py 1 2 50.0%
feeluown/player/metadata_assembler.py 0 8 0.0%
feeluown/library/ytdl.py 3 15 20.0%
Files with Coverage Reduction New Missed Lines %
feeluown/task.py 1 92.59%
feeluown/player/metadata_assembler.py 1 59.32%
feeluown/config.py 2 92.86%
Totals Coverage Status
Change from base Build 12102115394: -0.04%
Covered Lines: 9944
Relevant Lines: 17530
💛 - Coveralls

@cosven cosven merged commit dc7c848 into feeluown:master Dec 1, 2024
9 checks passed
@cosven cosven deleted the config-unknown-fields branch December 1, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cosven @coveralls