Skip to content
This repository has been archived by the owner on Jul 14, 2019. It is now read-only.

Allow progress up to 99999. #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kaj
Copy link

@kaj kaj commented May 9, 2017

I hope this fixes #15.

@fehmicansaglam
Copy link
Owner

Thanks for the PR. I suppose bar width will not be adjusted correctly but let me try it.

@kaj
Copy link
Author

kaj commented May 10, 2017

Hm. Maybe width should be capped to progressWidth? As it is, I don't think progress > 999 is a problem, but progress > scale won't look too good.

So maybe something like this on ProgressedIOServiceActor.scala line 28:

val width = progressWidth * min(progress, scale) / scale

?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support progress over 999
2 participants