Feat#59/tela de edit profile #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@R1K4S, está faltando algumas coisas. O código não está compilando. Você não está seguindo o padrão MVVM. Tome cuidado com métodos muito grandes. O construtor de EditProfile tem quase 200 linhas quebre ele em widgets menores. |
| import 'package:aranduapp/ui/shared/CustomTextField.dart'; | ||
| import 'package:aranduapp/ui/shared/TextPassword.dart'; | ||
|
|
||
| class EditProfile extends StatelessWidget { |
There was a problem hiding this comment.
O MVVM não está implementado nesta classe
| EditProfile({Key? key}) : super(key: key); | ||
|
|
||
| @override | ||
| Widget build(BuildContext context) { |
There was a problem hiding this comment.
Esse construtor está muito grande quebre ele em widgets menores
|
Beleza |
lib/ui/shared/CustomTextField.dart
Outdated
| final String label; | ||
| final String? placeholder; | ||
| final TextEditingController? controller; | ||
| final bool obscureText; |
There was a problem hiding this comment.
O MVVM não está implementado nessa classe
GabrielCostaDeOliveira
force-pushed
the
feat#59/Tela-de-EditProfile
branch
from
a1d60a5 to
125d664
Compare
GabrielCostaDeOliveira
force-pushed
the
feat#59/Tela-de-EditProfile
branch
from
125d664 to
b8a0d84
Compare
GabrielCostaDeOliveira
temporarily deployed
to
actions
GitHub Actions
Inactive
GabrielCostaDeOliveira
pushed a commit
that referenced
this pull request
Dec 9, 2024
[QA] adding sonarcloud workflow (fga-eps-mds/2024.2-ARANDU-DOC#23)
GabrielCostaDeOliveira
pushed a commit
that referenced
this pull request
Dec 9, 2024
[FIX] fixing script to generate metrics (fga-eps-mds/2024.2-ARANDU-DOC#23)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FEATURE] Criação da tela EditProfile (#59)
Descrição
Este pull request adiciona classes e pastas que envolvam a parte de Gerenciamento do Usuário,como EditProfile que se encontra a tela de alteração de informações do Usuário,criação do componente CustomFieldText para criar placeholder,criação do componente de ProfileCard que seria apresentação do usuário conforme previsto na issue #59.
Revisão
Checklist