fix#59/melhora menssagem de erro e ajusta casos de teste (fga-eps-mds/2024.2-ARANDU-DOC#59) #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GabrielCostaDeOliveira
requested changes
Dec 24, 2024
| @@ -17,8 +17,14 @@ class TextName extends StatelessWidget { | |||
| return Padding( | |||
| padding: padding, | |||
| child: TextFormField( | |||
| validator: (value) => | |||
| value == null || value.trim().length < 3 ? '$label inválido' : null, | |||
There was a problem hiding this comment.
Use $label nas suas mensagens de erro se vc quiser se referir ao nome do campo.
| @@ -43,10 +43,16 @@ class RegisterAccountViewModel extends ChangeNotifier { | |||
| ); | |||
| // Chamada do serviço de registro | |||
| await RegisterService.register(request); | |||
| ScaffoldMessenger.of(context).showSnackBar( | |||
There was a problem hiding this comment.
A view mode não deve ser responsável por nada visual, ela só deve ser responsvavel por comportamento e estados
a documentação explica o que deve estar em cada camada.
test/ui/Shared/TextName_test.dart
Outdated
| await testName(" a", 'Nome inválido'); // Nome com menos de 3 caracteres | ||
| await testName("Jo", 'Nome inválido'); // Nome com 2 caracteres | ||
| await testName("", 'Campo Obrigatório'); // Campo vazio | ||
| await testName(" a", 'Nome inválido (Ex: Ana)'); // Nome com menos de 3 caracteres |
There was a problem hiding this comment.
A mensagem deve explicar qual é o erro para que o usuario possa corrigir
"Digite pelo menos 3 caracteres visíveis. (Ex : Ana)"
…thub.com/fga-eps-mds/2024.2-ARANDU-APP into fix#59/ajusta-menssagem-register_account
|
GabrielCostaDeOliveira
approved these changes
Dec 26, 2024
GabrielCostaDeOliveira
temporarily deployed
to
actions
GitHub Actions
Inactive
GabrielCostaDeOliveira
deleted the
fix#59/ajusta-menssagem-register_account
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descrição
Este pull request adiciona/modifica register_account, shared e test , conforme previsto na issue fga-eps-mds/2024.2-ARANDU-DOC#59.
Revisão
Checklist