Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @lanzafame and @dannyob to fips-editors in place of @kaitlin-beagle #92

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

anorth
Copy link
Member

@anorth anorth commented Dec 20, 2024

Summary

Update FIP editors to match governance proposal filecoin-project/FIPs#1095.

Also removed a couple of legacy permissions to the FIPs repo.

Why do you need this?

FIP editor membership is decided by the FIP editor group. Members need write access to the FIPs repository.

What else do we need to know?

N/a

DRI: myself

Reviewer's Checklist

  • It is clear where the request is coming from (if unsure, ask)
  • All the automated checks passed
  • The YAML changes reflect the summary of the request
  • The Terraform plan posted as a comment reflects the summary of the request

@anorth anorth requested a review from a team as a code owner December 20, 2024 22:34
@anorth anorth changed the title Add @lanzafame and @dannyob to fips-editors in place of @kaitlinbeagle Add @lanzafame and @dannyob to fips-editors in place of @kaitlin-beagle Dec 20, 2024
Copy link
Contributor

github-actions bot commented Dec 20, 2024

The following access changes will be introduced as a result of applying the plan:

Access Changes
User andyschwab:
  - will lose push permission to fips
User dannyob:
  - will gain admin permission to fips
User kaitlin-beegle:
  - will lose admin permission to fips
User lanzafame:
  - will gain admin permission to fips

Copy link
Contributor

github-actions bot commented Dec 20, 2024

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

filecoin-project

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  - destroy

Terraform will perform the following actions:

  # github_repository_collaborator.this["fips:andyschwab"] will be destroyed
  # (because key ["fips:andyschwab"] is not in for_each map)
  - resource "github_repository_collaborator" "this" {
      - id         = "FIPs:andyschwab" -> null
      - permission = "push" -> null
      - repository = "FIPs" -> null
      - username   = "andyschwab" -> null
    }

  # github_repository_collaborator.this["fips:arajasek"] will be destroyed
  # (because key ["fips:arajasek"] is not in for_each map)
  - resource "github_repository_collaborator" "this" {
      - id         = "FIPs:arajasek" -> null
      - permission = "admin" -> null
      - repository = "FIPs" -> null
      - username   = "arajasek" -> null
    }

  # github_repository_collaborator.this["fips:kaitlin-beegle"] will be destroyed
  # (because key ["fips:kaitlin-beegle"] is not in for_each map)
  - resource "github_repository_collaborator" "this" {
      - id         = "FIPs:kaitlin-beegle" -> null
      - permission = "admin" -> null
      - repository = "FIPs" -> null
      - username   = "kaitlin-beegle" -> null
    }

  # github_team_membership.this["fips-editors:arajasek"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + team_id  = "5698214"
      + username = "arajasek"
    }

  # github_team_membership.this["fips-editors:dannyob"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + team_id  = "5698214"
      + username = "dannyob"
    }

  # github_team_membership.this["fips-editors:kaitlin-beegle"] will be destroyed
  # (because key ["fips-editors:kaitlin-beegle"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"8f06e2d2c6adfb71bd1737ee94b4998a89cc7c185998f548366c9fa161db5ef8\"" -> null
      - id       = "5698214:kaitlin-beegle" -> null
      - role     = "member" -> null
      - team_id  = "5698214" -> null
      - username = "kaitlin-beegle" -> null
    }

  # github_team_membership.this["fips-editors:lanzafame"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + team_id  = "5698214"
      + username = "lanzafame"
    }

  # github_team_repository.this["filoz:fips"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "push"
      + repository = "FIPs"
      + team_id    = "9934802"
    }

Plan: 4 to add, 0 to change, 4 to destroy.

@jsoares
Copy link
Member

jsoares commented Dec 20, 2024

Until we merge filecoin-project/FIPs#991, @arajasek remains listed as a FIP editor. In order to keep things consistent, maybe we shouldn't remove his permissions here.

@@ -5089,8 +5086,10 @@ teams:
- anorth
- jennijuju
member:
- arajasek
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- arajasek

Now that filecoin-project/FIPs#991 has been merged, let's remove @arajasek again 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants