lotus-miner: expose Config in StorageMiner; add SealingPipelineState API endpoint #7513
Conversation
nonsense
force-pushed
the
nonsense/sealing-pipeline-state
branch
from
31aeb4a to
15ed5cb
Compare
| jobs, err := sm.WorkerJobs(ctx) | ||
| if err != nil { | ||
| return nil, xerrors.Errorf("getting worker jobs: %w", err) | ||
| } |
There was a problem hiding this comment.
WorkerJobs is already exposed no the RPC
| @@ -60,6 +61,8 @@ type StorageMinerAPI struct { | |||
|
|
|||
| EnabledSubsystems api.MinerSubsystems | |||
|
|
|||
| Config *config.StorageMiner | |||
There was a problem hiding this comment.
At least the Sealing part of the config supports auto-reloading (this is why we have the getConfig function in the sealing package) - but just putting this config here like that won't get you updated values after changing the config on disk
There was a problem hiding this comment.
(side note: we really need to unify how we support dynamic config, and make that nicer / more fully supported)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7513 +/- ##
==========================================
- Coverage 39.86% 39.82% -0.04%
==========================================
Files 631 631
Lines 66913 66941 +28
==========================================
- Hits 26673 26662 -11
- Misses 35629 35659 +30
- Partials 4611 4620 +9
|
rjan90
added
area/miner-maintenance
need/author-input
|
Thank you for submitting the PR and contributing to lotus! Lotus maintainers need more of your input before merging it, please address the suggested changes or reply to the comments or this PR will be closed in 72 hours. You are always more than welcome to reopen the PR later as well! |
|
Thank you for submitting the PR and contributing to lotus! Lotus maintainers need more of your input before merging it, please address the suggested changes or reply to the comments or this PR will be closed in 72 hours. You are always more than welcome to reopen the PR later as well! |
|
Thank you for submitting the PR and contributing to lotus! Lotus maintainers need more of your input before merging it, please address the suggested changes or reply to the comments or this PR will be closed in 72 hours. You are always more than welcome to reopen the PR later as well! |
|
Closing PR as stale, will follow up and fix why stalebot was unable to do it automatically in: #12799 |
This PR is exposing the lotus-miner StorageMiner Config, as well as adding a SealingPipelineState API to be consumed by the markets node to determine if a miner is available to accept new deals.
The idea is to improve the
deal acceptance filterto take into account the state of the sealing pipeline when accepting deals.