This repository has been archived by the owner on Jun 6, 2023. It is now read-only.
refactor: add reward actor params and code gen #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this is a temportay workaround until the actor implements a AMT.
frrist
commented
Jan 22, 2020
|
|
||
| type RewardActorState struct { | ||
| RewardMap RewardBalanceAMT | ||
| // TODO AMT | ||
| RewardBalanceAMT cid.Cid |
There was a problem hiding this comment.
Eventually the actor state will look something like this with methods to modify its AMT. Until then we need to work around polydawn/refmt#35. cc @anorth is this strategy okay with you or should we do the work to convert this to an AMT now?
There was a problem hiding this comment.
Given the amount of code that needed to be commented out, and hence outside the scope of refactoring tools, I think we should wait until we can put an AMT here.
I don't think numbers as keys are a problem here, but maybe addresses? In the interim, we could use Address.Bytes() as the key.
|
Will revisit after the H/AMT TODO's addressed, ideally #39 will help with this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.