-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: setup dependabot and GHA CI #5
Conversation
Signed-off-by: Miroslav Bajtoš <[email protected]>
@juliangruber hindsight please 🙏🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, why did you go for a multiple workspaces layout here?
push: | ||
branches: [main] | ||
pull_request: | ||
branches: [main] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this limitation isn't necessary, as it prevents PRs targeting other branches from running CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know why we have that limitation in spark-evaluate config?
But not in spark-api config:
Git blame pointed me to this PR:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should have explained that in the design doc. Cross-posting #3 (comment):
|
Based on https://github.com/filecoin-station/spark-stats/tree/main/.github,
with few tweaks to try out a better setup.
Links: