Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: setup dependabot and GHA CI #5

Merged
merged 1 commit into from
Sep 4, 2024
Merged

chore: setup dependabot and GHA CI #5

merged 1 commit into from
Sep 4, 2024

Conversation

Signed-off-by: Miroslav Bajtoš <[email protected]>
@bajtos bajtos requested a review from juliangruber September 4, 2024 08:08
@bajtos bajtos merged commit 80e7740 into main Sep 4, 2024
5 checks passed
@bajtos bajtos deleted the ci branch September 4, 2024 08:09
@bajtos
Copy link
Member Author

bajtos commented Sep 4, 2024

@juliangruber hindsight please 🙏🏻

Copy link
Member

@juliangruber juliangruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, why did you go for a multiple workspaces layout here?

push:
branches: [main]
pull_request:
branches: [main]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this limitation isn't necessary, as it prevents PRs targeting other branches from running CI

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#8

@bajtos
Copy link
Member Author

bajtos commented Sep 4, 2024

Out of curiosity, why did you go for a multiple workspaces layout here?

I should have explained that in the design doc.

Cross-posting #3 (comment):

Components:

  • indexer: background service owning the persisted data, similar to spark-evaluate and spark-observer
  • REST API server exposing that data - to be done later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants