Skip to content

Commit

Permalink
target api level 34 and re-enable hints
Browse files Browse the repository at this point in the history
  • Loading branch information
thatfiredev committed Aug 28, 2024
1 parent e856257 commit 0693dd2
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,10 @@ public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceStat

ImeHelper.setImeOnDoneListener(mEmailEditText, this);

// TODO(hackathon): figure out if we want to have autofill or not.
// if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O && getFlowParams().enableHints) {
// mEmailEditText.setImportantForAutofill(View.IMPORTANT_FOR_AUTOFILL_NO);
// }
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.UPSIDE_DOWN_CAKE &&
getFlowParams().enableCredentialsManager) {
mEmailEditText.setIsCredential(true);
}

mNextButton.setOnClickListener(this);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,10 +89,10 @@ public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceStat

mSmsTermsText.setText(getString(R.string.fui_sms_terms_of_service,
getString(R.string.fui_verify_phone_number)));
// TODO(hackathon): figure out if we want to have autofill or not.
// if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O && getFlowParams().enableHints) {
// mPhoneEditText.setImportantForAutofill(View.IMPORTANT_FOR_AUTOFILL_NO);
// }
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.UPSIDE_DOWN_CAKE &&
getFlowParams().enableCredentialsManager) {
mPhoneEditText.setIsCredential(true);
}
requireActivity().setTitle(getString(R.string.fui_verify_phone_number_title));

ImeHelper.setImeOnDoneListener(mPhoneEditText, () -> onNext());
Expand Down
4 changes: 2 additions & 2 deletions buildSrc/src/main/kotlin/Config.kt
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ object Config {
private const val kotlinVersion = "1.8.21"

object SdkVersions {
const val compile = 33
const val target = 33
const val compile = 34
const val target = 34
const val min = 21
}

Expand Down

0 comments on commit 0693dd2

Please sign in to comment.