Fix masternode payout spend

[levoncrypto]

Summary by CodeRabbit

• Bug Fixes

  • Improved handling of transaction inputs by updating the method for determining the previous output index, ensuring accurate transaction construction.

• Documentation

  • Minor adjustments made to comments for clarity, enhancing understanding of the code without affecting functionality.

[coderabbitai]

Walkthrough

The pull request modifies the tx_inputs method in the Trezor plugin for Electrum Dash, specifically changing how the previous output index is determined for transaction inputs. The implementation now references txin.prevout.out_idx instead of txin.nsequence, which affects the logic for constructing transaction input types. Minor adjustments in comments and formatting were also made, but they do not impact the functionality or logic of the code.

Changes

File	Change Summary
electrum_dash/plugins/trezor/trezor.py	Updated tx_inputs method to use txin.prevout.out_idx instead of txin.nsequence for determining the previous output index; minor comments and formatting adjustments made.

Poem

🐰 A Trezor tale of inputs bright,
Where indexes dance with coding might,
From sequence to prevout we leap,
A rabbit's logic, clean and deep!
Transaction magic, now refined ✨
With precision carefully designed 🔍

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 48a4389 and 541f1a3.

📒 Files selected for processing (1)

• electrum_dash/plugins/trezor/trezor.py (1 hunks)

🔇 Additional comments (1)

electrum_dash/plugins/trezor/trezor.py (1)

382-382: Correct fix: Using proper output index field for coinbase inputs

The change from txin.nsequence to txin.prevout.out_idx is the right approach. The nsequence field is meant for sequence numbers in the transaction input, while prevout.out_idx specifically represents the previous output index, which is what we need here for correctly constructing the transaction input type.

Let's verify this change doesn't introduce regressions by checking for other coinbase transaction handling in the codebase:

✅ Verification successful

Correct fix: Using proper output index field for coinbase inputs

The change from txin.nsequence to txin.prevout.out_idx is verified to be the correct approach based on the codebase analysis:

1. The TxInput class in transaction.py shows that nsequence is specifically designed for sequence numbers (default: 0xffffffff - 1), while prevout.out_idx is the proper field for previous output index.

2. Other hardware wallet plugins (Keepkey, Safe-T, Ledger) consistently use prevout.out_idx for the previous output index when handling transaction inputs.

3. The codebase shows that nsequence is used for its intended purpose of transaction sequence numbers, particularly in contexts like:

   • Transaction serialization
   • Lock time verification
   • PrivateSend functionality

This fix aligns the Trezor plugin's behavior with both the correct field semantics and the implementation patterns used across other hardware wallet plugins in the codebase.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for coinbase transaction handling patterns
rg -A 5 "is_coinbase_input|prevout\.out_idx|nsequence" --type python

Length of output: 101

---

Script:

#!/bin/bash
# Search for coinbase transaction handling patterns without file type restriction
rg -A 5 "is_coinbase_input|prevout\.out_idx|nsequence"

Length of output: 30266

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.