added Dutch translation and minor improvements #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closes #109 |
erciccione
suggested changes
Apr 23, 2024
PanderMusubi
force-pushed
the
dutchtranslation
branch
2 times, most recently
from
793b0d6 to
56c5e09
Compare
|
I have a friend of mine review the translation. Other question, do we have a testing/staging environment for the website so the translation can be viewed in the resulting website? This would also be beneficial for more translations that will be added in the future or major changes which influence translations. |
|
@PanderMusubi We are still trying to decide in #329. A CI file already exists, but does not generate previews at the moment. |
|
You can also run the website locally. See https://jekyllrb.com/docs/ |
erciccione
reviewed
Apr 26, 2024
PanderMusubi
force-pushed
the
dutchtranslation
branch
from
56c5e09 to
563f718
Compare
Thanks, see also #389 |
PanderMusubi
force-pushed
the
dutchtranslation
branch
from
563f718 to
d627981
Compare
erciccione
approved these changes
Apr 30, 2024
|
Perhaps find somebody via Discord? |
erciccione
reviewed
May 28, 2024
Co-authored-by: ErC <[email protected]>
Co-authored-by: ErC <[email protected]>
|
I've processed the feedback. Thanks. |
erciccione
reviewed
May 29, 2024
erciccione
approved these changes
May 31, 2024
justanwar
approved these changes
Jun 1, 2024
justanwar
pushed a commit
that referenced
this pull request
Oct 3, 2024
* added Dutch translation and minor improvements * Update _i18n/nl.yml Co-authored-by: ErC <[email protected]> * Update _i18n/nl.yml Co-authored-by: ErC <[email protected]> * remove empty lines --------- Co-authored-by: ErC <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.