Generate hashes and minimize code on prod build

firstandthird · Dec 18, 2018 · f38268a · f38268a
1 parent 4e3d6f4
commit f38268a
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 6 deletions.
diff --git a/paths.js b/paths.js
@@ -2,7 +2,7 @@ const path = require('path');
 
 const task = process.argv[2] || 'default';
 const env = process.env.NODE_ENV || 'production';
-const isProduction = env === 'production';
+const isProduction = task === 'prod' || env === 'production';
 const prefix = process.env.CK_PREFIX || 'clientkit';
 const baseConfig = process.env.CK_BASE_CONFIG || path.join(__dirname, 'conf');
 const primaryConfig = process.env.CK_CONFIG || path.join(process.cwd(), prefix);

diff --git a/webpack/configs/css/index.js b/webpack/configs/css/index.js
@@ -21,7 +21,7 @@ module.exports = config => {
     ]
   };
 
-  if (paths.isProduction || paths.task !== 'dev') {
+  if (paths.isProduction) {
     cssConfig.plugins.push(assetsManifest(config));
   }
 

diff --git a/webpack/configs/css/loader.js b/webpack/configs/css/loader.js
@@ -66,7 +66,7 @@ module.exports = config => {
     }
   };
 
-  if (cssConfig.minify || paths.task !== 'dev') {
+  if (cssConfig.minify || paths.isProduction) {
     postCSSLoader.options.plugins.push(require('cssnano')({
       zindex: false,
       reduceIdents: false

diff --git a/webpack/configs/js/index.js b/webpack/configs/js/index.js
@@ -21,7 +21,7 @@ module.exports = config => {
     plugins: []
   };
 
-  if (paths.isProduction || paths.task !== 'dev') {
+  if (paths.isProduction) {
     jsConfig.plugins.push(assetsManifest(config));
   }
 

diff --git a/webpack/configs/svg/index.js b/webpack/configs/svg/index.js
@@ -20,7 +20,7 @@ module.exports = config => {
     ]
   };
 
-  if (paths.isProduction || paths.task !== 'dev') {
+  if (paths.isProduction) {
     svgConfig.plugins.push(assetsManifest(config));
   }
 

diff --git a/webpack/get-config.js b/webpack/get-config.js
@@ -25,7 +25,7 @@ const getConfig = async () => {
       }
     },
     optimization: {
-      minimize: config.minify || paths.task !== 'dev',
+      minimize: config.minify || paths.isProduction,
       noEmitOnErrors: true
     },
     target: 'web',
-Original file line number
+Diff line change
@@ Expand Up / @@ -21,7 +21,7 @@ module.exports = config => { @@
         ]
       };
-      if (paths.isProduction || paths.task !== 'dev') {
+      if (paths.isProduction) {
         cssConfig.plugins.push(assetsManifest(config));
       }
@@ Expand Down @@